Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566249

Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery

Show all headers | View raw

Hello Eric,

On 01/25/2017 11:41 AM, Eric W. Biederman wrote:
> "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
> 
>> Hi Eric,
>>
>> Do you have any input for this small patch set? I've still to tweak a
>> comment as suggested by Trevor King, but otherwise I'd like to know if
>> this is good to go for the next merge window.
> 
> Apologies I have been bogged down with other things.  Basically the
> code looks fine, and now that I have caught up with things I will be
> happy to merge your for the next merge window.

Thanks.

> I do wonder if returning -EOVERFLOW may be more useful than running
> the overflow_uid when mapping fails.

Yes, it I think you're right. I'll fix that.

> Also, now that I think about it.  Please let's use (uid_t __user *) for
> the type of argp.  I think that will be more maintainable in the long
> run.  Easier to grep for etc.

Yes, I'll make that change.

> Neither of these things are big or would prevent me from merging your
> change just things that I think would be nice to have.

Both seem worth having to me.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-01-24 22:40 +0100
  Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery ebiederm@xmission.com (Eric W. Biederman) - 2017-01-24 23:50 +0100
    Re: [PATCH v2 0/2] Add further ioctl() operations for namespace  discovery "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-01-25 01:40 +0100

csiph-web