Re: [PATCH 2/3] zswap: allow initialization at boot without pool

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] zswap: allow initialization at boot without pool
Date	2017-01-25 01:30 +0100
Message-ID	<t3jDj-2XM-15@gated-at.bofh.it> (permalink)
References	<t3fzI-kX-3@gated-at.bofh.it> <t3fzI-kX-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

just a note,

On (01/24/17 15:02), Dan Streetman wrote:
[..]
> @@ -692,6 +702,15 @@ static int __zswap_param_set(const char *val, const struct kernel_param *kp,
>  		 */
>  		list_add_tail_rcu(&pool->list, &zswap_pools);
>  		put_pool = pool;
> +	} else if (!zswap_has_pool) {
> +		/* if initial pool creation failed, and this pool creation also
> +		 * failed, maybe both compressor and zpool params were bad.
> +		 * Allow changing this param, so pool creation will succeed
> +		 * when the other param is changed. We already verified this
> +		 * param is ok in the zpool_has_pool() or crypto_has_comp()
> +		 * checks above.
> +		 */
> +		ret = param_set_charp(s, kp);
>  	}
>  
>  	spin_unlock(&zswap_pools_lock);

looks like there still GFP_KERNEL allocation from atomic section:
param_set_charp()->kmalloc_parameter()->kmalloc(GFP_KERNEL), under
`zswap_pools_lock'.

	-ss

Thread

[PATCH 0/3] Fix zswap init failure behavior Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
  [PATCH 3/3] zswap: clear compressor or zpool param if invalid at init Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
  [PATCH 2/3] zswap: allow initialization at boot without pool Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
    Re: [PATCH 2/3] zswap: allow initialization at boot without pool Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-01-25 01:30 +0100
      Re: [PATCH 2/3] zswap: allow initialization at boot without pool Dan Streetman <ddstreet@ieee.org> - 2017-01-25 17:40 +0100
  [PATCH 1/3] zswap: disable changing params if init fails Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
    Re: [PATCH 1/3] zswap: disable changing params if init fails Andrew Morton <akpm@linux-foundation.org> - 2017-01-24 22:30 +0100
      Re: [PATCH 1/3] zswap: disable changing params if init fails Dan Streetman <ddstreet@ieee.org> - 2017-01-24 23:20 +0100

csiph-web