[PATCH 0/3] Fix zswap init failure behavior

From	Dan Streetman <ddstreet@ieee.org>
Newsgroups	linux.kernel
Subject	[PATCH 0/3] Fix zswap init failure behavior
Date	2017-01-24 21:10 +0100
Message-ID	<t3fzI-kX-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If zswap fails to initialize itself at boot, it returns error from its
init function; but for built-in drivers, that does not unload them; and
more importantly, it doesn't prevent their sysfs module param interface
from being created.  In this case, changing the compressor or zpool param
will result in a WARNING because zswap didn't expect them to be changed if
initialization failed.

These patches fix that assumption, as well as allowing pool creation after
a failed initialization, if only the zpool and/or compressor creation
failed.

Dan Streetman (3):
  zswap: disable changing params if init fails
  zswap: allow initialization at boot without pool
  zswap: clear compressor or zpool param if invalid at init

 mm/zswap.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 100 insertions(+), 25 deletions(-)

-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Fix zswap init failure behavior Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
  [PATCH 3/3] zswap: clear compressor or zpool param if invalid at init Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
  [PATCH 2/3] zswap: allow initialization at boot without pool Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
    Re: [PATCH 2/3] zswap: allow initialization at boot without pool Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-01-25 01:30 +0100
      Re: [PATCH 2/3] zswap: allow initialization at boot without pool Dan Streetman <ddstreet@ieee.org> - 2017-01-25 17:40 +0100
  [PATCH 1/3] zswap: disable changing params if init fails Dan Streetman <ddstreet@ieee.org> - 2017-01-24 21:10 +0100
    Re: [PATCH 1/3] zswap: disable changing params if init fails Andrew Morton <akpm@linux-foundation.org> - 2017-01-24 22:30 +0100
      Re: [PATCH 1/3] zswap: disable changing params if init fails Dan Streetman <ddstreet@ieee.org> - 2017-01-24 23:20 +0100

csiph-web