Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567536
| From | "João Paulo Rechi Vita" <jprvita@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} |
| Date | 2017-01-26 16:40 +0100 |
| Message-ID | <t3Ujv-Eh-15@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
This quirk avoids the conflicting usage of ASUS_WMI_DEVID_WLAN_LED (0x00010002) by both asus-wireless and asus-wmi on machines where the BIOS can't set and record the wlan status (wlan_ctrl_by_user in asus-wmi.c). At the moment we have six models using that quirk upstream, but there are another fifteen for which we have downstream patches, and will send upstream unless we find a more dynamic solution. We also expect this list to continue growing. This series makes use of ASUS_WMI_DSTS_USER_BIT plus the status of the ASHS device to skip asus_wmi_rfkill_init(). Since asus-wmi now needs to know the ASHS _HIDs, I have moved device_ids[] to a new header file, asus-wireless.h. I'm not sure if there are any best practices in the kernel community against having one module including headers from a different module, but I wanted to avoid duplicating this list or creating an ordering dependency between the modules. Any advice on alternatives here are welcome. PS: I don't think asus-wireless.h needs to also be listed in MAINTAINERS, please correct me if I'm wrong. João Paulo Rechi Vita (8): Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA" Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF" Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA" Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB" Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW" Revert "asus-wmi: Create quirk for airplane_mode LED" asus-wireless: Export ids list asus-wmi: Don't register rfkill if ASHS and user bit are present drivers/platform/x86/asus-nb-wmi.c | 49 ++---------------------------------- drivers/platform/x86/asus-wireless.c | 15 +++++------ drivers/platform/x86/asus-wireless.h | 10 ++++++++ drivers/platform/x86/asus-wmi.c | 21 ++++++++++++---- drivers/platform/x86/asus-wmi.h | 1 - 5 files changed, 34 insertions(+), 62 deletions(-) create mode 100644 drivers/platform/x86/asus-wireless.h -- 2.11.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
[PATCH 4/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB" "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
[PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present Joe Perches <joe@perches.com> - 2017-01-27 00:00 +0100
[PATCH 2/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF" "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
[PATCH 5/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW" "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
[PATCH 7/8] asus-wireless: Export ids list "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
Re: [PATCH 7/8] asus-wireless: Export ids list Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-27 16:40 +0100
[PATCH 3/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA" "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-01-26 16:40 +0100
Re: [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-27 16:40 +0100
csiph-web