Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567499
| From | Dave Hansen <dave.hansen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state |
| Date | 2017-01-26 16:10 +0100 |
| Message-ID | <t3TQu-uN-25@gated-at.bofh.it> (permalink) |
| References | <t3HFD-1sp-5@gated-at.bofh.it> <t3HFD-1sp-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/25/2017 05:57 PM, riel@redhat.com wrote: > /* > + * Restoring SSE/YMM state requires that MXCSR & MXCSR_MASK are saved. > + * Those fields are part of the legacy FP state, and only get saved > + * above if XFEATURES_MASK_FP is set. > + * > + * Copy out those fields if we have SSE/YMM but no FP register data. > + */ Patch looks functionally good to me. One nit on the comment, though: Usually XSAVE "state" refers to the state in the CPU while the "area" refers to the buffer in memory. Probably best to talk about the "legacy FP area", not state. Maybe something like this for the first paragraph: MXCSR and MXCSR_MASK are part of the SSE and YMM states and are saved/restored along with those states. However, they are located in the legacy FP *area* of the XSAVE buffer.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] x86/fpu: copyout_from_xsaves & copyin_to_xsaves fixes riel@redhat.com - 2017-01-26 03:10 +0100
[PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state riel@redhat.com - 2017-01-26 03:10 +0100
Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Ingo Molnar <mingo@kernel.org> - 2017-01-26 09:20 +0100
[PATCH] x86/fpu: Rename copyin_to_xsaves()/copyout_from_xsaves() to copy_user_to_xstate()/copy_xstate_to_user() Ingo Molnar <mingo@kernel.org> - 2017-01-26 09:30 +0100
Re: [PATCH] x86/fpu: Rename copyin_to_xsaves()/copyout_from_xsaves() to copy_user_to_xstate()/copy_xstate_to_user() Ingo Molnar <mingo@kernel.org> - 2017-01-26 11:30 +0100
Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Dave Hansen <dave.hansen@linux.intel.com> - 2017-01-26 16:10 +0100
Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Yu-cheng Yu <yu-cheng.yu@intel.com> - 2017-01-30 18:40 +0100
csiph-web