[PATCH 0/2] x86/fpu: copyout_from_xsaves & copyin_to_xsaves fixes

From	riel@redhat.com
Newsgroups	linux.kernel
Subject	[PATCH 0/2] x86/fpu: copyout_from_xsaves & copyin_to_xsaves fixes
Date	2017-01-26 03:10 +0100
Message-ID	<t3HFD-1sp-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There are two issues with copyout_from_xsaves and copyin_to_xsaves.

The first is a simple bounds checking issue, where the code could
potentially clobber memory outside of a userspace buffer before it
stops copying data.

The second is more subtle. SSE and YMM XRSTOR depend on two fields
inside the legacy FP area. However, if xfeatures XFEATURE_MASK_FP is
clear, those fields do not get copied around at all. Fix that.

Thanks to Dave Hansen for helping track down that second bug.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] x86/fpu: copyout_from_xsaves & copyin_to_xsaves fixes riel@redhat.com - 2017-01-26 03:10 +0100
  [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state riel@redhat.com - 2017-01-26 03:10 +0100
    Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Ingo Molnar <mingo@kernel.org> - 2017-01-26 09:20 +0100
      [PATCH] x86/fpu: Rename copyin_to_xsaves()/copyout_from_xsaves() to  copy_user_to_xstate()/copy_xstate_to_user() Ingo Molnar <mingo@kernel.org> - 2017-01-26 09:30 +0100
        Re: [PATCH] x86/fpu: Rename copyin_to_xsaves()/copyout_from_xsaves()  to copy_user_to_xstate()/copy_xstate_to_user() Ingo Molnar <mingo@kernel.org> - 2017-01-26 11:30 +0100
    Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Dave Hansen <dave.hansen@linux.intel.com> - 2017-01-26 16:10 +0100
    Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Yu-cheng Yu <yu-cheng.yu@intel.com> - 2017-01-30 18:40 +0100

csiph-web