Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data Integrity)

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data Integrity)
Date	Wed, 25 Jan 2017 23:20:01 +0100
Message-ID	<t3E53-7DH-9@gated-at.bofh.it> (permalink)
References	<t3BTz-63B-7@gated-at.bofh.it> <t3BTA-63B-35@gated-at.bofh.it> <t3DVn-7zF-5@gated-at.bofh.it>
X-Original-To	rob.gardner@oracle.com
X-Mailer	Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jan 2017 13:14:28 -0800 (PST)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	12
Organization	linux.* mail to news gateway
X-Original-Cc	khalid.aziz@oracle.com, corbet@lwn.net, viro@zeniv.linux.org.uk, nitin.m.gupta@oracle.com, mike.kravetz@oracle.com, akpm@linux-foundation.org, mingo@kernel.org, kirill.shutemov@linux.intel.com, adam.buchbinder@gmail.com, hughd@google.com, minchan@kernel.org, keescook@chromium.org, chris.hyser@oracle.com, atish.patra@oracle.com, cmetcalf@mellanox.com, atomlin@redhat.com, jslaby@suse.cz, joe@perches.com, paul.gortmaker@windriver.com, mhocko@suse.com, lstoakes@gmail.com, jack@suse.cz, dave.hansen@linux.intel.com, vbabka@suse.cz, dan.j.williams@intel.com, iamjoonsoo.kim@lge.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, khalid@gonehiking.org
X-Original-Date	Wed, 25 Jan 2017 17:13:28 -0500 (EST)
X-Original-Message-ID	<20170125.171328.1978684823149751445.davem@davemloft.net>
X-Original-References	<cover.1485362562.git.khalid.aziz@oracle.com> <0b6865aabc010ee3a7ea956a70447abbab53ea70.1485362562.git.khalid.aziz@oracle.com> <154bc417-6333-f9ac-653b-9ed280f08450@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1566998

Show key headers only | View raw

From: Rob Gardner <rob.gardner@oracle.com>
Date: Wed, 25 Jan 2017 15:00:42 -0700

> Same comment here, and the various other places that employ this same
> code construct.

Please do not quote an entire huge patch just to comment on a small
part of it.

Quote only the minimum necessary context in order to provide your feedback.

Thank you.

Thread

[PATCH v5 0/4] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz <khalid.aziz@oracle.com> - 2017-01-25 21:00 +0100
  [PATCH v5 1/4] signals, sparc: Add signal codes for ADI violations Khalid Aziz <khalid.aziz@oracle.com> - 2017-01-25 21:00 +0100
  [PATCH v5 3/4] sparc64: Add support for ADI register fields, ASIs and traps Khalid Aziz <khalid.aziz@oracle.com> - 2017-01-25 21:00 +0100
  Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data  Integrity) David Miller <davem@davemloft.net> - 2017-01-25 23:20 +0100
  Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data  Integrity) Khalid Aziz <khalid.aziz@oracle.com> - 2017-01-25 23:30 +0100
    Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data  Integrity) Rob Gardner <rob.gardner@oracle.com> - 2017-01-26 00:00 +0100
      Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data  Integrity) Khalid Aziz <khalid.aziz@oracle.com> - 2017-01-26 00:00 +0100

csiph-web