Re: [PATCH RFC] tpm: define a command filter

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] tpm: define a command filter
Date	2017-01-25 23:20 +0100
Message-ID	<t3E53-7DH-7@gated-at.bofh.it> (permalink)
References	<t2WQq-581-29@gated-at.bofh.it> <t2X05-5ci-1@gated-at.bofh.it> <t3aql-5sP-1@gated-at.bofh.it> <t3eDD-8cr-7@gated-at.bofh.it> <t3CmC-6vC-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 25, 2017 at 10:21:37PM +0200, Jarkko Sakkinen wrote:

> There should be anyway someway to limit what commands can be sent but
> I understand your point.

What is the filter for?

James and I talked about a filter to create a safer cdev for use by
users. However tpms0 cannot be that 'safer' cdev - it is now the 'all
access' path.

I also suggested a filter in the kernel to ensure that the RM is only
passing commands it actually knows it handles properly. eg you would
filter out list handles. That is hardwired into the kernel, and does
not ge to be configured by user space.

> Would it make more sense to have a sysfs file for configuring the
> global filter that would get the data in the same format (list of
> 16-bit words)?

Probably not, then there is no way to escape the filter in userspace,
so some command just become impossible even for root. (And no,
something like tpm should not test CAP_ flags, that is putting
too much policy into the kernel)

Jason

Thread

[PATCH RFC] tpm: define a command filter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-24 01:10 +0100
  Re: [PATCH RFC] tpm: define a command filter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-24 01:20 +0100
    Re: [PATCH RFC] tpm: define a command filter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-24 15:40 +0100
      Re: [PATCH RFC] tpm: define a command filter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-24 20:10 +0100
        Re: [PATCH RFC] tpm: define a command filter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-25 21:30 +0100
          Re: [PATCH RFC] tpm: define a command filter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-25 23:20 +0100
            Re: [PATCH RFC] tpm: define a command filter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-26 12:20 +0100
              Re: [PATCH RFC] tpm: define a command filter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-26 19:10 +0100
                Re: [PATCH RFC] tpm: define a command filter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-27 07:50 +0100

csiph-web