Re: [PATCH 2/4] ARM: nommu: dynamic exception base address setting

From	Afzal Mohammed <afzal.mohd.ma@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] ARM: nommu: dynamic exception base address setting
Date	2017-01-22 04:40 +0100
Message-ID	<t2hax-3T4-3@gated-at.bofh.it> (permalink)
References	<t15bt-o6-55@gated-at.bofh.it> <t15bt-o6-53@gated-at.bofh.it> <t1lpT-2eh-3@gated-at.bofh.it> <t1KeD-16c-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Fri, Jan 20, 2017 at 09:50:22PM +0530, Afzal Mohammed wrote:
> On Thu, Jan 19, 2017 at 01:59:09PM +0000, Vladimir Murzin wrote:

> > You can use
> > 
> >     cpuid_feature_extract(CPUID_EXT_PFR1, 4)
> >     
> > and add a comment explaining what we are looking for and why.

W.r.t comments, tried to keep it concise, C tokens doing a part of it.

> Yes, that is better, was not aware of this, did saw CPUID_EXT_PFR1 as
> an unused macro.

> > > +#ifdef CONFIG_CPU_CP15
> > > +	vectors_base = setup_vectors_base();
> > > +#endif
> > 
> > alternatively it can be
> > 
> > 	unsigned long vector_base = IS_ENABLED(CONFIG_CPU_CP15) ? setup_vbar() : 0;
> 
> Yes that certainly is better.

Have kept the function name as setup_vector_base() as in addition to
setting up VBAR, V bit also has to be configured by it - so that
function name remains true to it's name.

v2 with changes has been posted.

Regards
afzal

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] ARM: nommu: dynamic exception base address setting afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 21:40 +0100
  Re: [PATCH 2/4] ARM: nommu: dynamic exception base address setting Vladimir Murzin <vladimir.murzin@arm.com> - 2017-01-19 15:00 +0100
    Re: [PATCH 2/4] ARM: nommu: dynamic exception base address setting Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2017-01-20 17:30 +0100
      Re: [PATCH 2/4] ARM: nommu: dynamic exception base address setting Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2017-01-22 04:40 +0100

csiph-web