Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564905

Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max()

Show all headers | View raw

On Mon, Jan 23, 2017 at 11:00:15AM +0100, SF Markus Elfring wrote:
> >> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file *of,
> >>  			break;
> >>  		ctx.body += len;
> >>  
> >> -		ret = -EINVAL;
> >>  		p = tok;
> >>  		strsep(&p, "=");
> >> -		if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max")))
> >> +		if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max"))) {
> >> +			ret = -EINVAL;
> >>  			goto out_finish;
> >> +		}
> > 
> > Sorry, I don't like this patch. We know the next error if we encounter one
> > will be EINVAL until we change it.
> 
> Thanks for your constructive feedback.
> 
> 
> > Your patch doesn't introduce a functual change and doesn't improve readability,
> > so I don't really see a point for it.
> 
> We have got different preferences for the placement of error code settings.
Yes we do, so what's the point? Both are OK. Please don't go down that road it
opens so much potential for needless bikeshedding and waste all of our
(including your) time.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] blk-throttle: Move three assignments for the variable  "ret" in tg_set_max() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-22 09:40 +0100
  Re: [PATCH 1/5] blk-throttle: Move three assignments for the  variable "ret" in tg_set_max() Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-23 10:20 +0100
    Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable  "ret" in tg_set_max() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-23 11:10 +0100
      Re: [PATCH 1/5] blk-throttle: Move three assignments for the  variable "ret" in tg_set_max() Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-23 12:50 +0100
        Re: blk-throttle: Move three assignments for the variable "ret" in  tg_set_max() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-23 13:10 +0100
          Re: blk-throttle: Move three assignments for the variable "ret" in  tg_set_max() Jens Axboe <axboe@kernel.dk> - 2017-01-23 16:20 +0100

csiph-web