Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564746

[tip:x86/debug] x86/crash: Update the stale comment in reserve_crashkernel()

Show all headers | View raw

Commit-ID:  a8d4c8246b290ce97f88752d833804843041ac84
Gitweb:     http://git.kernel.org/tip/a8d4c8246b290ce97f88752d833804843041ac84
Author:     Xunlei Pang <xlpang@redhat.com>
AuthorDate: Mon, 23 Jan 2017 14:48:23 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 23 Jan 2017 08:57:55 +0100

x86/crash: Update the stale comment in reserve_crashkernel()

CRASH_KERNEL_ADDR_MAX has been missing for a long time,
update it with a more detailed explanation.

Signed-off-by: Xunlei Pang <xlpang@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Baoquan He <bhe@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Young <dyoung@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kexec@lists.infradead.org
Link: http://lkml.kernel.org/r/1485154103-18426-1-git-send-email-xlpang@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/setup.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 4cfba94..eb69b14 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,9 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory,
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "crashkernel=size[KMG],high" is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/crash: Update the stale comment in reserve_crashkernel() Xunlei Pang <xlpang@redhat.com> - 2017-01-23 07:50 +0100
  [tip:x86/debug] x86/crash: Update the stale comment in  reserve_crashkernel() tip-bot for Xunlei Pang <tipbot@zytor.com> - 2017-01-23 09:10 +0100
  Re: [PATCH v2] x86/crash: Update the stale comment in  reserve_crashkernel() Dave Young <dyoung@redhat.com> - 2017-01-23 09:50 +0100
    Re: [PATCH v2] x86/crash: Update the stale comment in  reserve_crashkernel() Xunlei Pang <xpang@redhat.com> - 2017-01-23 14:30 +0100

csiph-web