[PATCH v2] x86/crash: Update the stale comment in reserve_crashkernel()

From	Xunlei Pang <xlpang@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] x86/crash: Update the stale comment in reserve_crashkernel()
Date	2017-01-23 07:50 +0100
Message-ID	<t2GBX-32t-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

CRASH_KERNEL_ADDR_MAX has been missing for a long time,
update it with more detailed explanation.

Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: Xunlei Pang <xlpang@redhat.com>
---
 arch/x86/kernel/setup.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 4cfba94..c32a167 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,9 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "crashkernel=size[KMG],high" is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/crash: Update the stale comment in reserve_crashkernel() Xunlei Pang <xlpang@redhat.com> - 2017-01-23 07:50 +0100
  [tip:x86/debug] x86/crash: Update the stale comment in  reserve_crashkernel() tip-bot for Xunlei Pang <tipbot@zytor.com> - 2017-01-23 09:10 +0100
  Re: [PATCH v2] x86/crash: Update the stale comment in  reserve_crashkernel() Dave Young <dyoung@redhat.com> - 2017-01-23 09:50 +0100
    Re: [PATCH v2] x86/crash: Update the stale comment in  reserve_crashkernel() Xunlei Pang <xpang@redhat.com> - 2017-01-23 14:30 +0100

csiph-web