Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564153

Re: [alsa-devel] [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks

Show all headers | View raw

Thanks for the review Stephen.

On 1/20/17 5:58 PM, Stephen Boyd wrote:
> On 01/17, Pierre-Louis Bossart wrote:
>> diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
>> new file mode 100644
>> index 0000000..312d4e9
>> --- /dev/null
>> +++ b/drivers/clk/x86/clk-pmc-atom.c
> [...]
>> +
>> +static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32 val)
>> +{
>> +	u32 tmp;
>> +	unsigned long flags;
>> +
>> +	spin_lock_irqsave(&clk->lock, flags);
>> +
>> +	tmp = clk_readl(clk->reg);
>
> Do you need to use clk_readl? I'd prefer we deleted that
> function/macro because it's just confusing. Please don't use it
> unless you need it for some reason.

I just followed Andy's recommendation and will revert to readl/writel, 
as well as fix the nitpicks below
>
>> +	tmp = (tmp & ~mask) | (val & mask);
>> +	clk_writel(tmp, clk->reg);
>> +
>> +	spin_unlock_irqrestore(&clk->lock, flags);
>> +}
>> +
> [..]
>> +
>> +static void plt_clk_unregister_parents(struct clk_plt_data *data)
>> +{
>> +	plt_clk_unregister_fixed_rate_loop(data, data->nparents);
>> +}
>> +
>> +
>
> Nitpick: Single newline please

ok

>> +static struct platform_driver plt_clk_driver = {
>> +	.driver = {
>> +		.name = PLT_CLK_DRIVER_NAME,
>
> Nitpick: Just put the string here

ok

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/5] Add platform clock for BayTrail platforms Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:10 +0100
  [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:10 +0100
    Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:00 +0100
      Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-21 15:00 +0100
      Re: [alsa-devel] [PATCH v7 2/5] clk: x86: Add Atom PMC platform  clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-21 17:30 +0100
  [PATCH v7 3/5] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
    Re: [PATCH v7 3/5] arch/x86/platform/atom: Move pmc_atom to  drivers/platform/x86 Thomas Gleixner <tglx@linutronix.de> - 2017-01-18 10:30 +0100
  [PATCH v7 5/5] platform/x86: fix typo in comment Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
  [PATCH v7 4/5] platform/x86: Enable Atom PMC platform clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
  Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 12:00 +0100
    Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:10 +0100
      Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-21 12:00 +0100
        Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Stephen Boyd <sboyd@codeaurora.org> - 2017-01-27 01:20 +0100

csiph-web