Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564118
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks |
| Date | 2017-01-21 15:00 +0100 |
| Message-ID | <t24mZ-4Eu-5@gated-at.bofh.it> (permalink) |
| References | <t0K70-4fM-11@gated-at.bofh.it> <t0K70-4fM-9@gated-at.bofh.it> <t1Rg5-5kW-9@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Fri, 2017-01-20 at 15:58 -0800, Stephen Boyd wrote:
> On 01/17, Pierre-Louis Bossart wrote:
> >
> > +static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32
> > val)
> > +{
> > + u32 tmp;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&clk->lock, flags);
> > +
> > + tmp = clk_readl(clk->reg);
>
> Do you need to use clk_readl? I'd prefer we deleted that
> function/macro because it's just confusing.
Good to know.
> Please don't use it
> unless you need it for some reason.
It was my suggestion, I didn't know that the mentioned API is kinda
deprecated.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 0/5] Add platform clock for BayTrail platforms Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:10 +0100
[PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:10 +0100
Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:00 +0100
Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-21 15:00 +0100
Re: [alsa-devel] [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-21 17:30 +0100
[PATCH v7 3/5] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
Re: [PATCH v7 3/5] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Thomas Gleixner <tglx@linutronix.de> - 2017-01-18 10:30 +0100
[PATCH v7 5/5] platform/x86: fix typo in comment Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
[PATCH v7 4/5] platform/x86: Enable Atom PMC platform clocks Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2017-01-17 23:20 +0100
Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 12:00 +0100
Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:10 +0100
Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-21 12:00 +0100
Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms Stephen Boyd <sboyd@codeaurora.org> - 2017-01-27 01:20 +0100
csiph-web