Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564115
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jonathan Cameron <jic23@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume |
| Date | Sat, 21 Jan 2017 14:20:02 +0100 |
| Message-ID | <t23Ki-4sh-17@gated-at.bofh.it> (permalink) |
| References | <sZK94-63T-5@gated-at.bofh.it> <t0iDL-30L-11@gated-at.bofh.it> |
| X-Original-To | "Andrew F. Davis" <afd@ti.com>, Alison Schofield <amsfield22@gmail.com> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 51 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 21 Jan 2017 13:12:00 +0000 |
| X-Original-Message-ID | <21e9df05-1918-cb17-d83a-e2c36e70851b@kernel.org> |
| X-Original-References | <20170115035141.GA19547@d830.WORKGROUP> <9fc37bb7-0a0c-cf68-51e5-c91d096262d7@ti.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1564115 |
Show key headers only | View raw
On 16/01/17 16:38, Andrew F. Davis wrote:
> On 01/14/2017 09:51 PM, Alison Schofield wrote:
>> The suspend/resume functions were using dev_to_iio_dev() to get
>> the iio_dev. That only works on IIO dev's. Replace it with spi
>> functions to get the correct iio_dev.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>
> Was this found with an automated tool? If not, it might be nice to have
> a Coccinelle style check for this. Anyway for this and the afe4404
> version patch:
>
> Acked-by: Andrew F. Davis <afd@ti.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
>> ---
>> drivers/iio/health/afe4403.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
>> index 9a08146..6bb23a4 100644
>> --- a/drivers/iio/health/afe4403.c
>> +++ b/drivers/iio/health/afe4403.c
>> @@ -422,7 +422,7 @@ MODULE_DEVICE_TABLE(of, afe4403_of_match);
>>
>> static int __maybe_unused afe4403_suspend(struct device *dev)
>> {
>> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>> struct afe4403_data *afe = iio_priv(indio_dev);
>> int ret;
>>
>> @@ -443,7 +443,7 @@ static int __maybe_unused afe4403_suspend(struct device *dev)
>>
>> static int __maybe_unused afe4403_resume(struct device *dev)
>> {
>> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>> struct afe4403_data *afe = iio_priv(indio_dev);
>> int ret;
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume Jonathan Cameron <jic23@kernel.org> - 2017-01-21 14:20 +0100
csiph-web