Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559882

Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume

Show all headers | View raw

On 01/14/2017 09:51 PM, Alison Schofield wrote:
> The suspend/resume functions were using dev_to_iio_dev() to get
> the iio_dev. That only works on IIO dev's.  Replace it with spi
> functions to get the correct iio_dev.
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>

Was this found with an automated tool? If not, it might be nice to have
a Coccinelle style check for this. Anyway for this and the afe4404
version patch:

Acked-by: Andrew F. Davis <afd@ti.com>

> ---
>  drivers/iio/health/afe4403.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
> index 9a08146..6bb23a4 100644
> --- a/drivers/iio/health/afe4403.c
> +++ b/drivers/iio/health/afe4403.c
> @@ -422,7 +422,7 @@ MODULE_DEVICE_TABLE(of, afe4403_of_match);
>  
>  static int __maybe_unused afe4403_suspend(struct device *dev)
>  {
> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> +	struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>  	struct afe4403_data *afe = iio_priv(indio_dev);
>  	int ret;
>  
> @@ -443,7 +443,7 @@ static int __maybe_unused afe4403_suspend(struct device *dev)
>  
>  static int __maybe_unused afe4403_resume(struct device *dev)
>  {
> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> +	struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>  	struct afe4403_data *afe = iio_priv(indio_dev);
>  	int ret;
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume Alison Schofield <amsfield22@gmail.com> - 2017-01-15 05:00 +0100
  Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume "Andrew F. Davis" <afd@ti.com> - 2017-01-16 17:50 +0100
    Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume Alison Schofield <amsfield22@gmail.com> - 2017-01-16 19:20 +0100
      Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume "Andrew F. Davis" <afd@ti.com> - 2017-01-16 19:30 +0100
        Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume Alison Schofield <amsfield22@gmail.com> - 2017-01-16 19:40 +0100
    Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in  suspend/resume Jonathan Cameron <jic23@kernel.org> - 2017-01-21 14:20 +0100

csiph-web