Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563200
| From | "Grandhi, Sainath" <sainath.grandhi@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver |
| Date | 2017-01-20 00:40 +0100 |
| Message-ID | <t1utb-83Y-7@gated-at.bofh.it> (permalink) |
| References | <t0LZ7-5nf-3@gated-at.bofh.it> <t0LZ8-5nf-37@gated-at.bofh.it> <t15XR-Vm-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, January 18, 2017 1:29 PM
> To: Grandhi, Sainath <sainath.grandhi@intel.com>
> Cc: netdev@vger.kernel.org; mahesh@bandewar.net; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver
>
> From: Sainath Grandhi <sainath.grandhi@intel.com>
> Date: Tue, 17 Jan 2017 16:03:06 -0800
>
> > +static void ipvtap_count_tx_dropped(struct tap_dev *tap) {
> > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
> ...
> > +static void ipvtap_count_rx_dropped(struct tap_dev *tap) {
> > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
> ...
> > +static void ipvtap_update_features(struct tap_dev *tap,
> > + netdev_features_t features)
> > +{
> > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
> > +ipvtap_dev, tap);
>
> More unnecessary casts, please remove.
Will take care of it in next revision. Thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
[PATCHv2 1/7] TAP: Refactoring macvtap.c Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
[PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver David Miller <davem@davemloft.net> - 2017-01-18 22:30 +0100
RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver "Grandhi, Sainath" <sainath.grandhi@intel.com> - 2017-01-20 00:40 +0100
[PATCHv2 6/7] TAP: tap as an independent module Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
[PATCHv2 3/7] TAP: Tap character device creation/destroy API Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API David Miller <davem@davemloft.net> - 2017-01-18 22:30 +0100
RE: [PATCHv2 3/7] TAP: Tap character device creation/destroy API "Grandhi, Sainath" <sainath.grandhi@intel.com> - 2017-01-20 00:40 +0100
csiph-web