Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563199

RE: [PATCHv2 3/7] TAP: Tap character device creation/destroy API

Show all headers | View raw

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, January 18, 2017 1:27 PM
> To: Grandhi, Sainath <sainath.grandhi@intel.com>
> Cc: netdev@vger.kernel.org; mahesh@bandewar.net; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API
> 
> From: Sainath Grandhi <sainath.grandhi@intel.com>
> Date: Tue, 17 Jan 2017 16:03:02 -0800
> 
> > +int tap_create_cdev(struct cdev *tap_cdev,
> > +		    dev_t *tap_major, const char *device_name) {
> > +	int err;
> > +
> > +	err = alloc_chrdev_region(tap_major, 0, TAP_NUM_DEVS,
> device_name);
> > +
> > +	if (err)
> > +		goto out1;
> 
> No need to have an empty line between the alloc_chrdev_region() call and
> the "if (err)" test.
> 
> > diff --git a/include/linux/if_tap.h b/include/linux/if_tap.h index
> > d887aaa..a2dfd90 100644
> > --- a/include/linux/if_tap.h
> > +++ b/include/linux/if_tap.h
> > @@ -10,7 +10,7 @@ struct file;
> >  struct socket;
> >  static inline struct socket *tap_get_socket(struct file *f)  {
> > -        return ERR_PTR(-EINVAL);
> > +	return ERR_PTR(-EINVAL);
> >  }
> 
> Instead of having to fix up the indentation here, get it right in the first place in
> patch #2.

Will work on these two comments in next version.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
  [PATCHv2 1/7] TAP: Refactoring macvtap.c Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
  [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
    Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver David Miller <davem@davemloft.net> - 2017-01-18 22:30 +0100
      RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver "Grandhi, Sainath" <sainath.grandhi@intel.com> - 2017-01-20 00:40 +0100
  [PATCHv2 6/7] TAP: tap as an independent module Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
  [PATCHv2 3/7] TAP: Tap character device creation/destroy API Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
    Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API David Miller <davem@davemloft.net> - 2017-01-18 22:30 +0100
      RE: [PATCHv2 3/7] TAP: Tap character device creation/destroy API "Grandhi, Sainath" <sainath.grandhi@intel.com> - 2017-01-20 00:40 +0100

csiph-web