Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1562612

[PATCH] net: atm: Fix build error when !CONFIG_PROC_FS

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Augusto Mecking Caringi <augustocaringi@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS
Date Thu, 19 Jan 2017 12:10:02 +0100
Message-ID <t1iLo-MP-7@gated-at.bofh.it> (permalink)
X-Original-To "David S . Miller" <davem@davemloft.net>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0PHi9zObBx4ua8kQT874X28dNySq13eIDQjANHbgqLY=; b=aT0GWUW0kYOKSntGxJCJ91HeO1FY2SxTElfWzfpp/em4zPSKRgK+V8kI39kZJTSRzO XFNyTEFxJqaRpxHxyiiQZVTr27RbqU9nD4OBDWCb2JgTb7wsYdCV9+A++rtPBwEMT/HD AkLWKu1CuQpAzartnOxQ0FTkaPd5lW16ImkrdEwLTO8hiSUmt/yiDpVhp48aZQI40tCI Jffuo+CKArIQUf/GgfhKdMA943I+Wj9UAoNSTZxuHRa48hk4/h6ACL2V6NJxswTo1tse CmKgX2oM3I27sSouGmChrb0AY61kainO8LC0EZAp8VqgziuFBFdkD9ZDYXB/DdmIF8gp +pJg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0PHi9zObBx4ua8kQT874X28dNySq13eIDQjANHbgqLY=; b=tQ3lRUG/vqYHZX24aulT0r3pkR+qDyI+Y7R0y0JlUSlBOK0FuvPW19rnMHQ8zA3Fkj s5MZCXAix+iiBlBB5LnHe9WfIdqXrPGf7EkrvPXRdBaZt2WfwusZ2Q+nJQLiCHgFJMCk /6+LYyZbC1E5toWUyVyfOlxoQ6HpWxQnR7NeT0lH0BjDBOQ6Sup94P1HT4KrqA5bGQFt OzkOplyF3pbtw4SaJfoOHL81Xl/FhjyKvL2REBmHCLBQ/JK8/yzX6NcL1hvcT+1CG9gx PbUdYpz4P+HFJOrXPIwZg3Xf1U4L9iOaVWGGEpRcRwEbP4Xnv45msT824JLgCChc1F0x /TmA==
X-Gm-Message-State AIkVDXKxNqaVLw/UC2UpmDYpLRoKLR7CsgkqqQl9mEj/PZI+u+cQQ0gWc1Z7yAY3TVUkyQ==
X-Received by 10.46.21.25 with SMTP id s25mr3830099ljd.54.1484823640387; Thu, 19 Jan 2017 03:00:40 -0800 (PST)
X-Mailer git-send-email 2.7.4
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Content-Transfer-Encoding 8bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc Augusto Mecking Caringi <augustocaringi@gmail.com>, Jiri Pirko <jiri@mellanox.com>, Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 19 Jan 2017 11:00:12 +0000
X-Original-Message-ID <1484823626-8150-1-git-send-email-augustocaringi@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1562612

Show key headers only | View raw


When CONFIG_ATM_CLIP is set and CONFIG_PROC_FS is not set, the building
was failing whith the error:

net/atm/clip.c: In function ‘atm_clip_exit’:
net/atm/clip.c:933:27: error: ‘atm_proc_root’ undeclared (first use in
this function)
remove_proc_entry("arp", atm_proc_root);
                           ^

Fix it by putting the proc cleanup code inside a #ifdef CONFIG_PROC_FS
block.

Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
---
 net/atm/clip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/atm/clip.c b/net/atm/clip.c
index 53b4ac0..75221e4 100644
--- a/net/atm/clip.c
+++ b/net/atm/clip.c
@@ -930,7 +930,9 @@ static void atm_clip_exit_noproc(void)
 
 static void __exit atm_clip_exit(void)
 {
+#ifdef CONFIG_PROC_FS
 	remove_proc_entry("arp", atm_proc_root);
+#endif
 
 	atm_clip_exit_noproc();
 }
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: atm: Fix build error when !CONFIG_PROC_FS Augusto Mecking Caringi <augustocaringi@gmail.com> - 2017-01-19 12:10 +0100
  Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS David Miller <davem@davemloft.net> - 2017-01-19 17:40 +0100

csiph-web