Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562888

Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS

Show all headers | View raw

From: Augusto Mecking Caringi <augustocaringi@gmail.com>
Date: Thu, 19 Jan 2017 11:00:12 +0000

> When CONFIG_ATM_CLIP is set and CONFIG_PROC_FS is not set, the building
> was failing whith the error:
> 
> net/atm/clip.c: In function ‘atm_clip_exit’:
> net/atm/clip.c:933:27: error: ‘atm_proc_root’ undeclared (first use in
> this function)
> remove_proc_entry("arp", atm_proc_root);
>                            ^
> 
> Fix it by putting the proc cleanup code inside a #ifdef CONFIG_PROC_FS
> block.
> 
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>

When CONFIG_PROC_FS is not defined, remove_proc_entry is defined as the
macro:

#define remove_proc_entry(name, parent) do {} while (0)

Therefore it is impossible for atm_proc_root to be referened in any way.

The fallback macro is designed exactly so that ugly ifdefs like the one
you are proposing aren't necessary.

I'm not applyiing this patch, something else is happening in your tree.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: atm: Fix build error when !CONFIG_PROC_FS Augusto Mecking Caringi <augustocaringi@gmail.com> - 2017-01-19 12:10 +0100
  Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS David Miller <davem@davemloft.net> - 2017-01-19 17:40 +0100

csiph-web