Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562504

Re: [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 18, 2017 at 03:20:47PM +0100, Benjamin Gaignard wrote:
> This driver adds support for PWM driver on STM32 platform.
> The SoC have multiple instances of the hardware IP and each
> of them could have small differences: number of channels,
> complementary output, auto reload register size...
> 
> version 8:
> - fix comments done by Thierry on version 7
> 
> version 6:
> - change st,breakinput parameter to make it usuable for stm32f7 too.
> 
> version 4:
> - detect at probe time hardware capabilities
> - fix comments done on v2 and v3
> - use PWM atomic ops
> 
> version 2:
> - only keep one comptatible
> - use DT parameters to discover hardware block configuration
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
>  drivers/pwm/Kconfig     |   9 ++
>  drivers/pwm/Makefile    |   1 +
>  drivers/pwm/pwm-stm32.c | 398 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 408 insertions(+)
>  create mode 100644 drivers/pwm/pwm-stm32.c

Similar nit than for 3/8. The canonical prefix for PWM subsystem patches
is "pwm: ". One other thing that I had missed earlier...

> +MODULE_ALIAS("platform: stm32-pwm");

I don't think there should be a space after ':'.

With those two fixed:

Acked-by: Thierry Reding <treding@nvidia.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 8/8] ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 2/8] MFD: add STM32 Timers driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 6/8] IIO: add STM32 timer trigger driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Thierry Reding <thierry.reding@gmail.com> - 2017-01-19 10:20 +0100
  [PATCH v8 1/8] MFD: add bindings for STM32 Timers driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Thierry Reding <thierry.reding@gmail.com> - 2017-01-19 10:20 +0100
  [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Rob Herring <robh@kernel.org> - 2017-01-19 20:40 +0100
  [PATCH v8 7/8] ARM: dts: stm32: add Timers driver for stm32f429 MCU Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Lee Jones <lee.jones@linaro.org> - 2017-01-19 09:50 +0100
    Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-19 18:20 +0100
      Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Rob Herring <robh@kernel.org> - 2017-01-19 20:40 +0100

csiph-web