Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562500

Re: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 18, 2017 at 03:20:46PM +0100, Benjamin Gaignard wrote:
> Define bindings for pwm-stm32
> 
> version 8:
> - reword st,breakinput description.
> 
> version 6:
> - change st,breakinput parameter format to make it usuable on stm32f7 too.
> 
> version 2:
> - use parameters instead of compatible of handle the hardware configuration
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/pwm/pwm-stm32.txt          | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt

One last nit: please use "dt-bindings: pwm:" as prefix for the patch
subject. So it would read something like this:

	dt-bindings: pwm: Add STM32 bindings

or similar. That's the style that's been used for a while now. I'd have
fixed that up myself, but since Lee plans to take this through the MFD
tree I'd like to see that fixed up before it gets applied.

With the above:

Acked-by: Thierry Reding <thierry.reding@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 8/8] ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 2/8] MFD: add STM32 Timers driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 6/8] IIO: add STM32 timer trigger driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Thierry Reding <thierry.reding@gmail.com> - 2017-01-19 10:20 +0100
  [PATCH v8 1/8] MFD: add bindings for STM32 Timers driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Thierry Reding <thierry.reding@gmail.com> - 2017-01-19 10:20 +0100
  [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
    Re: [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Rob Herring <robh@kernel.org> - 2017-01-19 20:40 +0100
  [PATCH v8 7/8] ARM: dts: stm32: add Timers driver for stm32f429 MCU Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-18 15:30 +0100
  Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Lee Jones <lee.jones@linaro.org> - 2017-01-19 09:50 +0100
    Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-19 18:20 +0100
      Re: [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Rob Herring <robh@kernel.org> - 2017-01-19 20:40 +0100

csiph-web