Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563852

[PATCH 09/11] KVM: PPC: Book3S: Improve a size determination in two functions

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Jan 2017 16:28:43 +0100

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/powerpc/kvm/book3s_xics.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
index 3740f9efcf06..d45c1b59b70a 100644
--- a/arch/powerpc/kvm/book3s_xics.c
+++ b/arch/powerpc/kvm/book3s_xics.c
@@ -1032,7 +1032,7 @@ static struct kvmppc_ics *kvmppc_xics_create_ics(struct kvm *kvm,
 		goto out;
 
 	/* Create the ICS */
-	ics = kzalloc(sizeof(struct kvmppc_ics), GFP_KERNEL);
+	ics = kzalloc(*ics), GFP_KERNEL);
 	if (!ics)
 		goto out;
 
@@ -1064,7 +1064,7 @@ int kvmppc_xics_create_icp(struct kvm_vcpu *vcpu, unsigned long server_num)
 	if (kvmppc_xics_find_server(vcpu->kvm, server_num))
 		return -EEXIST;
 
-	icp = kzalloc(sizeof(struct kvmppc_icp), GFP_KERNEL);
+	icp = kzalloc(sizeof(*icp), GFP_KERNEL);
 	if (!icp)
 		return -ENOMEM;
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] PowerPC-KVM: Fine-tuning for some function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:20 +0100
  [PATCH 02/11] KVM: PPC: Book3S HV: Improve a size determination in  kvmppc_alloc_hpt() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 07/11] KVM: PPC: Book3S HV: Improve size determinations in  five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 01/11] KVM: PPC: Book3S HV: Move assignments for the variable  "err" in kvm_htab_write() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 01/11] KVM: PPC: Book3S HV: Move assignments for the  variable "err" in kvm_htab_write() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-23 15:20 +0100
  [PATCH 10/11] KVM: PPC: e500: Use kcalloc() in e500_mmu_host_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 04/11] KVM: PPC: Book3S HV: Use common error handling code in  kvmppc_clr_passthru_irq() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 03/11] KVM: PPC: Book3S HV: Move error code assignments in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 03/11] KVM: PPC: Book3S HV: Move error code assignments in  two functions Paolo Bonzini <pbonzini@redhat.com> - 2017-01-23 15:20 +0100
  [PATCH 06/11] KVM: PPC: Book3S HV: Use kcalloc() in  kvmppc_alloc_host_rm_ops() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 09/11] KVM: PPC: Book3S: Improve a size determination in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 09/11] KVM: PPC: Book3S: Improve a size determination in  two functions kbuild test robot <lkp@intel.com> - 2017-01-21 07:40 +0100
  [PATCH 11/11] KVM: PPC: Return directly after a failed  copy_from_user() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
  [PATCH 08/11] KVM: PPC: Book3S: Use seq_puts() in xics_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
  [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null  pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
    Re: [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null  pointers Thomas Huth <thuth@redhat.com> - 2017-01-23 20:30 +0100

csiph-web