Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563851

[PATCH 06/11] KVM: PPC: Book3S HV: Use kcalloc() in kvmppc_alloc_host_rm_ops()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Jan 2017 16:20:43 +0100

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Delete the local variable "size" which became unnecessary
  with this refactoring.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/powerpc/kvm/book3s_hv.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 3122998f6a32..596201b3f22e 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -3199,7 +3199,6 @@ void kvmppc_alloc_host_rm_ops(void)
 	struct kvmppc_host_rm_ops *ops;
 	unsigned long l_ops;
 	int cpu, core;
-	int size;
 
 	/* Not the first time here ? */
 	if (kvmppc_host_rm_ops_hv)
@@ -3209,9 +3208,9 @@ void kvmppc_alloc_host_rm_ops(void)
 	if (!ops)
 		return;
 
-	size = cpu_nr_cores() * sizeof(struct kvmppc_host_rm_core);
-	ops->rm_core = kzalloc(size, GFP_KERNEL);
-
+	ops->rm_core = kcalloc(cpu_nr_cores(),
+			       sizeof(*ops->rm_core),
+			       GFP_KERNEL);
 	if (!ops->rm_core) {
 		kfree(ops);
 		return;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] PowerPC-KVM: Fine-tuning for some function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:20 +0100
  [PATCH 02/11] KVM: PPC: Book3S HV: Improve a size determination in  kvmppc_alloc_hpt() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 07/11] KVM: PPC: Book3S HV: Improve size determinations in  five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 01/11] KVM: PPC: Book3S HV: Move assignments for the variable  "err" in kvm_htab_write() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 01/11] KVM: PPC: Book3S HV: Move assignments for the  variable "err" in kvm_htab_write() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-23 15:20 +0100
  [PATCH 10/11] KVM: PPC: e500: Use kcalloc() in e500_mmu_host_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 04/11] KVM: PPC: Book3S HV: Use common error handling code in  kvmppc_clr_passthru_irq() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 03/11] KVM: PPC: Book3S HV: Move error code assignments in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 03/11] KVM: PPC: Book3S HV: Move error code assignments in  two functions Paolo Bonzini <pbonzini@redhat.com> - 2017-01-23 15:20 +0100
  [PATCH 06/11] KVM: PPC: Book3S HV: Use kcalloc() in  kvmppc_alloc_host_rm_ops() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
  [PATCH 09/11] KVM: PPC: Book3S: Improve a size determination in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:30 +0100
    Re: [PATCH 09/11] KVM: PPC: Book3S: Improve a size determination in  two functions kbuild test robot <lkp@intel.com> - 2017-01-21 07:40 +0100
  [PATCH 11/11] KVM: PPC: Return directly after a failed  copy_from_user() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
  [PATCH 08/11] KVM: PPC: Book3S: Use seq_puts() in xics_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
  [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null  pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-20 19:40 +0100
    Re: [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null  pointers Thomas Huth <thuth@redhat.com> - 2017-01-23 20:30 +0100

csiph-web