Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563445
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM |
| Date | 2017-01-20 11:20 +0100 |
| Message-ID | <t1Esy-5Zp-17@gated-at.bofh.it> (permalink) |
| References | <t1tx7-7sA-9@gated-at.bofh.it> <t1tx7-7sA-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello,
On 01/19/2017 07:36 PM, Javier Martinez Canillas wrote:
> Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when
> CONFIG_PM is unset") removed the implicit dependency that the driver
> had with CONFIG_PM, since it relied on the config option to be enabled.
>
> In order to work with !CONFIG_PM, the GSC reset logic that happens in
> the runtime resume callback had to be executed on the probe function.
>
> But there's no need to do this if CONFIG_PM is enabled, since in this
> case the runtime PM resume callback will be called by VIDIOC_STREAMON
> ioctl, so the resume handler will call the GSC HW reset function.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Please ignore this patch as suggested by Marek in other thread.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 23:40 +0100 Re: [PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:20 +0100
csiph-web