Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563444
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator |
| Date | 2017-01-20 11:20 +0100 |
| Message-ID | <t1Esy-5Zp-11@gated-at.bofh.it> (permalink) |
| References | <t1tGN-7wg-1@gated-at.bofh.it> <t1tGN-7wg-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Jan 19, 2017 at 02:40:56PM -0800, Dmitry Torokhov wrote:
[...]
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index 9964c46468d3..7b213e0ab06c 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -14,6 +14,7 @@
> */
>
> #include <linux/input.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/of.h>
> @@ -25,30 +26,59 @@
> struct pwm_beeper {
> struct input_dev *input;
> struct pwm_device *pwm;
> + struct regulator *amplifier;
> struct work_struct work;
> unsigned long period;
> bool suspended;
> + bool amplifier_on;
Why do you need to track this? I thought regulator_enable() and
regulator_disable() were already reference counted?
Thierry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
[PATCH v2 5/7] Input: pwm-beeper - suppress error message on probe defer Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 5/7] Input: pwm-beeper - suppress error message on probe defer Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:20 +0100
Re: [PATCH v2 5/7] Input: pwm-beeper - suppress error message on probe defer David Lechner <david@lechnology.com> - 2017-01-20 19:50 +0100
[PATCH v2 2/7] Input: pwm-beeper - switch to using managed resources Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 2/7] Input: pwm-beeper - switch to using managed resources Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:20 +0100
[PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:20 +0100
Re: [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-20 18:50 +0100
[PATCH v2 4/7] Input: pwm-beeper - fix race when suspending Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 4/7] Input: pwm-beeper - fix race when suspending Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:20 +0100
[PATCH v2 3/7] Input: pwm-beeper - use input_set_capability() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 3/7] Input: pwm-beeper - use input_set_capability() Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:20 +0100
[PATCH v2 7/7] Input: pwm-beeper - switch to using "atomic" PWM API Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-19 23:50 +0100
Re: [PATCH v2 7/7] Input: pwm-beeper - switch to using "atomic" PWM API Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:40 +0100
Re: [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 11:10 +0100
Re: [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API David Lechner <david@lechnology.com> - 2017-01-20 20:40 +0100
csiph-web