Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1562036

Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection

From Mark Rutland <mark.rutland@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection
Date 2017-01-18 19:10 +0100
Message-ID <t12Qj-7py-29@gated-at.bofh.it> (permalink)
References (4 earlier) <t0Y9Y-4vs-29@gated-at.bofh.it> <t0YjE-4z4-31@gated-at.bofh.it> <t1025-5Fi-11@gated-at.bofh.it> <t10bM-5IB-19@gated-at.bofh.it> <t11hw-6lt-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 18, 2017 at 04:17:18PM +0000, Punit Agrawal wrote:
> Mark Rutland <mark.rutland@arm.com> writes:
> 
> > On Wed, Jan 18, 2017 at 02:51:31PM +0000, Punit Agrawal wrote:
> >> I should've clarified in my reply that I wasn't looking to support the
> >> third instance from Mark's examples above - "monitor all vCPUs on a
> >> pCPU". I think it'll be quite expensive to figure out which threads from
> >> a given pool are vCPUs.
> >
> > I'm not sure I follow why you would need to do that?
> >
> > In that case, we'd open a CPU-bound perf event for the pCPU, which would
> > get installed in the CPU context immediately. It would be present for
> > all tasks.
> >
> > Given it's present for all tasks, we don't need to figure out which
> > happen to have vCPUs. The !vCPU tasks simply shouldn't trigger events.
> >
> > Am I missing something?
> 
> When enabling a CPU-bound event for pCPU, we'd have to enable trapping
> of TLB operations for the vCPUs running on pCPU. Have a look at Patch
> 7/9.
> 
> Also, we'd have to enable/disable trapping when tasks are migrated
> between pCPUs.

Ah, so we can't configure the trap and leave it active, since it'll
affect the host.

We could have a per-cpu flag, and a hook into vcpu_run, but that's also
gnarly.

I'll have a think.

> So far I've assumed that a VM pid is immutable. If that doesn't hold
> then we need to think of another mechanism to refer to a VM from
> userspace.

Even if we can't migrate the VM between processes (i.e. it's immutable),
it's still not unique within a process, so I'm fairly sure we need
another mechanism (even if we get away with the common case today).

Thanks,
Mark.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 12:30 +0100
  Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 13:50 +0100
    Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 14:10 +0100
      Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 14:20 +0100
        Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 16:10 +0100
          Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 16:20 +0100
            Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 17:30 +0100
              Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 19:10 +0100
                Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Christoffer Dall <christoffer.dall@linaro.org> - 2017-01-19 17:50 +0100
                Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-23 12:30 +0100
      Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Will Deacon <will.deacon@arm.com> - 2017-01-18 14:50 +0100
        Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 16:00 +0100
  Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 14:10 +0100

csiph-web