Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection

From	Punit Agrawal <punit.agrawal@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection
Date	2017-01-18 16:00 +0100
Message-ID	<t0ZSq-5mL-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <sY36a-N3-35@gated-at.bofh.it> <t0WBb-3tQ-9@gated-at.bofh.it> <t0XQD-49m-21@gated-at.bofh.it> <t0Y9Y-4vs-29@gated-at.bofh.it> <t0YMG-4JP-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Will Deacon <will.deacon@arm.com> writes:

> On Wed, Jan 18, 2017 at 01:01:40PM +0000, Punit Agrawal wrote:
>> Mark Rutland <mark.rutland@arm.com> writes:
>> 
>> > On Wed, Jan 18, 2017 at 11:21:21AM +0000, Marc Zyngier wrote:
>> >> On 10/01/17 11:38, Punit Agrawal wrote:
>> >> > +#define VM_MASK	GENMASK_ULL(31, 0)
>> >> > +#define EVENT_MASK	GENMASK_ULL(32, 39)
>> >> > +#define EVENT_SHIFT	(32)
>> >> > +
>> >> > +#define to_pid(cfg)	((cfg) & VM_MASK)
>> >> > +#define to_event(cfg)	(((cfg) & EVENT_MASK) >> EVENT_SHIFT)
>> >> > +
>> >> > +PMU_FORMAT_ATTR(vm, "config:0-31");
>> >> > +PMU_FORMAT_ATTR(event, "config:32-39");
>> >> 
>> >> I'm a bit confused by these. Can't you get the PID of the VM you're
>> >> tracing directly from perf, without having to encode things?
>> 
>> With perf attached to a PID, the event gets scheduled out when the task
>> is context switched. As the PID of the controlling process was used,
>> none of the vCPU events were counted.
>
> So it sounds like userspace needs to deal with this by attaching to the PIDs
> of the vCPUs. Given that perf kvm seems to have knowledge of vCPUs, it would
> be nice to know why that logic isn't reusable here. Take a look in
> tools/perf/builtin-kvm.c and if it's not up to the job, then perhaps it can
> be improved.

Thanks for the pointer. I'll have a play with perf kvm to see if it can
be leveraged here.

>
> Will
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Thread

Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 12:30 +0100
  Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 13:50 +0100
    Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 14:10 +0100
      Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 14:20 +0100
        Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 16:10 +0100
          Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 16:20 +0100
            Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 17:30 +0100
              Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Mark Rutland <mark.rutland@arm.com> - 2017-01-18 19:10 +0100
                Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Christoffer Dall <christoffer.dall@linaro.org> - 2017-01-19 17:50 +0100
                Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-23 12:30 +0100
      Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM  introspection Will Deacon <will.deacon@arm.com> - 2017-01-18 14:50 +0100
        Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 16:00 +0100
  Re: [PATCH v3 6/9] kvm: arm/arm64: Add host pmu to support VM introspection Punit Agrawal <punit.agrawal@arm.com> - 2017-01-18 14:10 +0100

csiph-web