Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560420

Re: [PATCH] staging: fsl-mc: fix coding stye errors

Show all headers | View raw

On Tue, Jan 17, 2017 at 12:47:30AM -0800, Joe Perches wrote:
> On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> > On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > > Split line at boolean operator.
> > > 
> > > Error was reported by checkpatch.pl as
> > > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
> []
> > > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> []
> > > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void)
> > >  			continue;
> > >  		}
> > >  
> > > -		WARN_ON(mc_msi_domain->
> > > -				host_data != &its_fsl_mc_msi_domain_info);
> > > +		WARN_ON(mc_msi_domain->host_data !=
> > > +						&its_fsl_mc_msi_domain_info);
> > 
> > Better to line it up like this:
> > 
> > 		WARN_ON(mc_msi_domain->host_data !=
> > 			&its_fsl_mc_msi_domain_info);
> 
> At 81 chars, it might be better on a single line instead.
> 

Yeah.  Except you can't fight checkpatch.pl...  In the long run it will
just wear you down for no good reason.

> 		WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info);
> 
> It also might be better to shorten some of the identifiers.

Yeah.  Shorter names are a great idea.  This driver went a bit crazy
with all the prefixes.  It's a static variable.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fsl-mc: fix coding stye errors Dhananjay Balan <dhananjay@cliqz.com> - 2017-01-17 09:20 +0100
  Re: [PATCH] staging: fsl-mc: fix coding stye errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-17 09:30 +0100
    Re: [PATCH] staging: fsl-mc: fix coding stye errors Joe Perches <joe@perches.com> - 2017-01-17 09:50 +0100
      Re: [PATCH] staging: fsl-mc: fix coding stye errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-17 11:10 +0100
        [PATCH v2] staging: fsl-mc: fix coding stye errors Dhananjay Balan <dhananjay@cliqz.com> - 2017-01-18 12:00 +0100
          Re: [PATCH v2] staging: fsl-mc: fix coding stye errors Greg KH <gregkh@linuxfoundation.org> - 2017-01-18 12:30 +0100
          Re: [PATCH v2] staging: fsl-mc: fix coding stye errors Greg KH <gregkh@linuxfoundation.org> - 2017-01-18 18:30 +0100

csiph-web