Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560343

Re: [PATCH] staging: fsl-mc: fix coding stye errors

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: fsl-mc: fix coding stye errors
Date 2017-01-17 09:30 +0100
Message-ID <t0xjs-4DL-21@gated-at.bofh.it> (permalink)
References <t0x9M-4At-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> Split line at boolean operator.
> 
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
> 
> Signed-off-by: Dhananjay Balan <dhananjay@cliqz.com>
> ---
>  drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> index 6b1cd57..6b19a21 100644
> --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void)
>  			continue;
>  		}
>  
> -		WARN_ON(mc_msi_domain->
> -				host_data != &its_fsl_mc_msi_domain_info);
> +		WARN_ON(mc_msi_domain->host_data !=
> +						&its_fsl_mc_msi_domain_info);

Better to line it up like this:

		WARN_ON(mc_msi_domain->host_data !=
			&its_fsl_mc_msi_domain_info);

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fsl-mc: fix coding stye errors Dhananjay Balan <dhananjay@cliqz.com> - 2017-01-17 09:20 +0100
  Re: [PATCH] staging: fsl-mc: fix coding stye errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-17 09:30 +0100
    Re: [PATCH] staging: fsl-mc: fix coding stye errors Joe Perches <joe@perches.com> - 2017-01-17 09:50 +0100
      Re: [PATCH] staging: fsl-mc: fix coding stye errors Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-17 11:10 +0100
        [PATCH v2] staging: fsl-mc: fix coding stye errors Dhananjay Balan <dhananjay@cliqz.com> - 2017-01-18 12:00 +0100
          Re: [PATCH v2] staging: fsl-mc: fix coding stye errors Greg KH <gregkh@linuxfoundation.org> - 2017-01-18 12:30 +0100
          Re: [PATCH v2] staging: fsl-mc: fix coding stye errors Greg KH <gregkh@linuxfoundation.org> - 2017-01-18 18:30 +0100

csiph-web