Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1560212

RE: [PATCH RFC 0/4] 5-level EPT

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From "Li, Liang Z" <liang.z.li@intel.com>
Newsgroups linux.kernel
Subject RE: [PATCH RFC 0/4] 5-level EPT
Date Tue, 17 Jan 2017 03:20:01 +0100
Message-ID <t0rxn-Rx-3@gated-at.bofh.it> (permalink)
References <sTFlL-4Oj-7@gated-at.bofh.it> <sV7SG-5kc-17@gated-at.bofh.it>
X-Original-To Paolo Bonzini <pbonzini@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.33,242,1477983600"; d="scan'208";a="809643845"
Thread-Topic [PATCH RFC 0/4] 5-level EPT
Thread-Index AQHSYbaExl9WnUhCuEaDs9125fzcHqEkeYYAgBeR13A=
Accept-Language zh-CN, en-US
Content-Language en-US
X-Originating-IP [10.239.127.40]
Content-Type text/plain; charset="utf-8"
Content-Transfer-Encoding base64
MIME-Version 1.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "guangrong.xiao@linux.intel.com" <guangrong.xiao@linux.intel.com>, "rkrcmar@redhat.com" <rkrcmar@redhat.com>, "Neiger, Gil" <gil.neiger@intel.com>, "Lai, Paul C" <paul.c.lai@intel.com>
X-Original-Date Tue, 17 Jan 2017 02:18:36 +0000
X-Original-Message-ID <F2CBF3009FA73547804AE4C663CAB28E3C35386E@shsmsx102.ccr.corp.intel.com>
X-Original-References <1483003563-25847-1-git-send-email-liang.z.li@intel.com> <9ddf602b-6c8b-8c1e-ab46-07ed12366593@redhat.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1560212

Show key headers only | View raw


> On 29/12/2016 10:25, Liang Li wrote:
> > x86-64 is currently limited physical address width to 46 bits, which
> > can support 64 TiB of memory. Some vendors require to support more for
> > some use case. Intel plans to extend the physical address width to
> > 52 bits in some of the future products.
> >
> > The current EPT implementation only supports 4 level page table, which
> > can support maximum 48 bits physical address width, so it's needed to
> > extend the EPT to 5 level to support 52 bits physical address width.
> >
> > This patchset has been tested in the SIMICS environment for 5 level
> > paging guest, which was patched with Kirill's patchset for enabling
> > 5 level page table, with both the EPT and shadow page support. I just
> > covered the booting process, the guest can boot successfully.
> >
> > Some parts of this patchset can be improved. Any comments on the
> > design or the patches would be appreciated.
> 
> I will review the patches.  They seem fairly straightforward.
> 
> However, I am worried about the design of the 5-level page table feature
> with respect to migration.
> 
> Processors that support the new LA57 mode can write 57-canonical/48-
> noncanonical linear addresses to some registers even when LA57 mode is
> inactive.  This is true even of unprivileged instructions, in particular
> WRFSBASE/WRGSBASE.
> 
> This is fairly bad because, if a guest performs such a write (because of a bug
> or because of malice), it will not be possible to migrate the virtual machine to
> a machine that lacks LA57 mode.
> 
> Ordinarily, hypervisors trap CPUID to hide features that are only present in
> some processors of a heterogeneous cluster, and the hypervisor also traps
> for example CR4 writes to prevent enabling features that were masked away.
> In this case, however, the only way for the hypervisor to prevent the write
> would be to run the guest with
> CR4.FSGSBASE=0 and trap all executions of WRFSBASE/WRGSBASE.  This
> might have negative effects on performance for workloads that use the
> instructions.
> 
> Of course, this is a problem even without your patches.  However, I think it
> should be addressed first.  I am seriously thinking of blacklisting FSGSBASE
> completely on LA57 machines until the above is fixed in hardware.
> 
> Paolo

The issue has already been forwarded to the hardware guys, still waiting for the feedback.

Thanks!
Liang

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

RE: [PATCH RFC 0/4] 5-level EPT "Li, Liang Z" <liang.z.li@intel.com> - 2017-01-17 03:20 +0100

csiph-web