Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559940

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

Show all headers | View raw

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 16 Jan 2017 09:29:51 -0800

> On Sat, 14 Jan 2017 13:08:28 +0100
> Philippe Reynes <tremyfr@gmail.com> wrote:
> 
>> The ethtool api {get|set}_settings is deprecated.
>> We move this driver to new api {get|set}_link_ksettings.
>> 
>> The callback set_link_ksettings no longer update the value
>> of advertising, as the struct ethtool_link_ksettings is
>> defined as const.
>> 
>> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> 
> Did you test this on real hardware?

Philippe probably doesn't have physical access to most of the
drivers he is converting.

But, he is the only person working on converting all of the drivers,
and therefore when the change looks straightforward I am going to
reward his work and effort by applying his changes and hope there
isn't any fallout.

Those who really care can test his patches and give a Tested-by:

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-01-14 13:10 +0100
  Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2017-01-16 18:40 +0100
    Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings Stephen Hemminger <stephen@networkplumber.org> - 2017-01-16 19:00 +0100
      Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-01-16 22:30 +0100
  Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings Stephen Hemminger <stephen@networkplumber.org> - 2017-01-16 18:40 +0100

csiph-web