Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: marvell: skge: use new api ethtool_{get\|set}_link_ksettings
Date	2017-01-16 18:40 +0100
Message-ID	<t0jqa-3zg-31@gated-at.bofh.it> (permalink)
References	<sZvjH-5Nh-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 14 Jan 2017 13:08:28 +0100
Philippe Reynes <tremyfr@gmail.com> wrote:

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
> 
> The callback set_link_ksettings no longer update the value
> of advertising, as the struct ethtool_link_ksettings is
> defined as const.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Did you test this on real hardware?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-01-14 13:10 +0100
  Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2017-01-16 18:40 +0100
    Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings Stephen Hemminger <stephen@networkplumber.org> - 2017-01-16 19:00 +0100
      Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-01-16 22:30 +0100
  Re: [PATCH] net: marvell: skge: use new api  ethtool_{get|set}_link_ksettings Stephen Hemminger <stephen@networkplumber.org> - 2017-01-16 18:40 +0100

csiph-web