Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559843

Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int

Show all headers | View raw

On Fri, Jan 13, 2017 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redundant. Remove the check and the associated
> dev_err error message.

Not sure why I got copied on this...

> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------

This file doesn't exist in mainline.

>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> index 3b86d3d..a345166 100644
> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
>         r = iod->reg_data;
>
>         offset = ti_iodelay_pin_to_offset(iod, pin);
> -       if (pin < 0) {

Shouldn't this be "if (offset < 0)"?


> -               dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
> -
> -               return;
> -       }
> -
>         pd = &iod->pa[pin];
>         cfg = pd->drv_data;
>
> --
> 2.10.2
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int Colin King <colin.king@canonical.com> - 2017-01-13 22:10 +0100
  Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Nishanth Menon <nm@ti.com> - 2017-01-14 17:50 +0100
  Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Rob Herring <robh@kernel.org> - 2017-01-16 16:50 +0100
    Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Colin Ian King <colin.king@canonical.com> - 2017-01-16 17:00 +0100

csiph-web