[PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
Date	2017-01-13 22:10 +0100
Message-ID	<sZhgK-5N3-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

pin is an unsigned int and therefore can never be < 0 so
this check is redundant. Remove the check and the associated
dev_err error message.

Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index 3b86d3d..a345166 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
 	r = iod->reg_data;
 
 	offset = ti_iodelay_pin_to_offset(iod, pin);
-	if (pin < 0) {
-		dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
-
-		return;
-	}
-
 	pd = &iod->pa[pin];
 	cfg = pd->drv_data;
 
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int Colin King <colin.king@canonical.com> - 2017-01-13 22:10 +0100
  Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Nishanth Menon <nm@ti.com> - 2017-01-14 17:50 +0100
  Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Rob Herring <robh@kernel.org> - 2017-01-16 16:50 +0100
    Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check  on unsigned int Colin Ian King <colin.king@canonical.com> - 2017-01-16 17:00 +0100

csiph-web