Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1559689
| Path | csiph.com!news.freedyn.net!open-news-network.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table |
| Date | Mon, 16 Jan 2017 13:40:02 +0100 |
| Message-ID | <t0eJQ-nt-15@gated-at.bofh.it> (permalink) |
| References | <sZaff-1qE-3@gated-at.bofh.it> <t09h8-4Tq-21@gated-at.bofh.it> <sZaff-1qE-1@gated-at.bofh.it> <t09h8-4Tq-19@gated-at.bofh.it> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 24 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Laxman Dewangan <ldewangan@nvidia.com>, Krzysztof Kozlowski <krzk@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Lee Jones <lee.jones@linaro.org> |
| X-Original-Date | Mon, 16 Jan 2017 09:30:14 -0300 |
| X-Original-Message-ID | <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com> |
| X-Original-References | <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <CGME20170113133435epcas4p47bc9f122524db29df3dc94b208a64385@epcas4p4.samsung.com> <1484314449-10060-5-git-send-email-javier@osg.samsung.com> <587C6C36.5070606@samsung.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1559689 |
Show key headers only | View raw
Hello Chanwoo, Thanks for the review. On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > Hi, > > I think that this patch better to squash with patch3. > After applying the patch3, this driver doesn't use > the max77686_i2c_id table. > I usually prefer to separate each change in a different patch, AFAICT moving to use the .probe_new callback and removing the I2C id table are two different changes. I can squash if that's the correct approach though, I will let Lee decide. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-13 14:40 +0100
Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-16 07:50 +0100
Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 13:40 +0100
Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Lee Jones <lee.jones@linaro.org> - 2017-01-23 12:40 +0100
Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Lee Jones <lee.jones@linaro.org> - 2017-01-23 12:40 +0100
csiph-web