Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561685
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/4] alpha: Return directly after a failed copy_from_user() or getname() in two functions |
| Date | 2017-01-18 13:00 +0100 |
| Message-ID | <t0X4e-3E5-19@gated-at.bofh.it> (permalink) |
| References | <t0WUy-3AT-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 18 Jan 2017 11:30:06 +0100 Return directly after a call of the function "copy_from_user" or "getname" failed at the beginning. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/alpha/kernel/osf_sys.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index 73ff5d698591..4310bc79d09c 100644 --- a/arch/alpha/kernel/osf_sys.c +++ b/arch/alpha/kernel/osf_sys.c @@ -454,16 +454,13 @@ osf_ufs_mount(const char __user *dirname, struct cdfs_args tmp; struct filename *devname; - retval = -EFAULT; if (copy_from_user(&tmp, args, sizeof(tmp))) - goto out; + return -EFAULT; devname = getname(tmp.devname); - retval = PTR_ERR(devname); if (IS_ERR(devname)) - goto out; + return PTR_ERR(devname); retval = do_mount(devname->name, dirname, "ext2", flags, NULL); putname(devname); - out: return retval; } @@ -475,16 +472,13 @@ osf_cdfs_mount(const char __user *dirname, struct cdfs_args tmp; struct filename *devname; - retval = -EFAULT; if (copy_from_user(&tmp, args, sizeof(tmp))) - goto out; + return -EFAULT; devname = getname(tmp.devname); - retval = PTR_ERR(devname); if (IS_ERR(devname)) - goto out; + return PTR_ERR(devname); retval = do_mount(devname->name, dirname, "iso9660", flags, NULL); putname(devname); - out: return retval; } -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] alpha: Fine-tuning for five function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 12:50 +0100
[PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 13:00 +0100
Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() Jan-Benedict Glaw <jbglaw@lug-owl.de> - 2017-01-18 14:40 +0100
Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 15:30 +0100
Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() Al Viro <viro@ZenIV.linux.org.uk> - 2017-01-18 15:20 +0100
Re: alpha: Checking source code positions for the setting of error codes SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 17:00 +0100
Re: alpha: Checking source code positions for the setting of error codes Al Viro <viro@ZenIV.linux.org.uk> - 2017-01-18 18:50 +0100
Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() kbuild test robot <lkp@intel.com> - 2017-01-19 01:50 +0100
[PATCH 3/4] alpha: Return directly after a failed copy_from_user() or getname() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 13:00 +0100
[PATCH 2/4] alpha: Move two assignments for the variable "error" in osf_utsname() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 13:00 +0100
csiph-web