Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI
Date	2017-01-17 15:50 +0100
Message-ID	<t0Dfb-8i5-9@gated-at.bofh.it> (permalink)
References	<t0Bdn-768-15@gated-at.bofh.it> <t0Bdo-768-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Neil,

Thank you for the patch.

On Tuesday 17 Jan 2017 13:31:33 Neil Armstrong wrote:
> If the input pixel format is not RGB, the CSC must be enabled in order to
> provide valid pixel to DVI sinks.
> This patch removes the hdmi only dependency on the CSC enabling.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c
> b/drivers/gpu/drm/bridge/dw-hdmi.c index 923e250..8a6a183 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1331,8 +1331,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi
> *hdmi) hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS);
>  	}
> 
> -	/* Enable color space conversion if needed (for HDMI sinks only). */
> -	if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi))
> +	/* Enable color space conversion if needed */
> +	if (is_color_space_conversion(hdmi))
>  		hdmi_writeb(hdmi, 
HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH,
>  			    HDMI_MC_FLOWCTRL);
>  	else

-- 
Regards,

Laurent Pinchart

Thread

[RFC/RFT PATCH 0/4] drm/bridge: dw-hdmi: Add support for Custom PHYs Neil Armstrong <narmstrong@baylibre.com> - 2017-01-17 13:40 +0100
  [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI Neil Armstrong <narmstrong@baylibre.com> - 2017-01-17 13:40 +0100
    Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-17 15:50 +0100
    Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI Jose Abreu <Jose.Abreu@synopsys.com> - 2017-01-18 11:40 +0100
      Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI Neil Armstrong <narmstrong@baylibre.com> - 2017-01-18 12:30 +0100
  [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data Neil Armstrong <narmstrong@baylibre.com> - 2017-01-17 13:40 +0100
    Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-17 16:00 +0100
    Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from  plat_data Jose Abreu <Jose.Abreu@synopsys.com> - 2017-01-18 11:40 +0100
      Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from  plat_data Neil Armstrong <narmstrong@baylibre.com> - 2017-01-18 12:30 +0100
        Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-18 22:00 +0100
          Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from  plat_data Jose Abreu <Jose.Abreu@synopsys.com> - 2017-01-19 16:30 +0100
            Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-01-19 17:50 +0100
            Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from  plat_data Hans Verkuil <hansverk@cisco.com> - 2017-01-19 18:00 +0100

csiph-web