Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1514704

Re: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and PHIR3MWAIT bit

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and PHIR3MWAIT bit
Date 2016-11-03 18:10 +0100
Message-ID <sztGy-6N2-13@gated-at.bofh.it> (permalink)
References <syEkF-7nA-3@gated-at.bofh.it> <syEkF-7nA-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 1 Nov 2016, Grzegorz Andrejczuk wrote:
>  
> +/* Intel Xeon Phi x200 ring 3 MONITOR/MWAIT */

Oh well. I asked you to make that whole PHI thing go away.

This is a feature which has nothing to do with PHI. It just happens to be
implemented on PHI. The FEATURES_ENABLES MSR is not at all PHI specific.

It's all about a feature which enables ring 3 mwait/monitor.

> +#define MSR_MISC_FEATURE_ENABLES	0x00000140
> +#define MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT_BIT	1
> +#define MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT	(1ULL << MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT_BIT)
> +

You really try hard to get your crap behind me. Stop sending out half baken
shit every other day without addressing my review comments.

Your trust level approaches negative space.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and PHIR3MWAIT bit Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-11-01 11:20 +0100
  Re: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and  PHIR3MWAIT bit Borislav Petkov <bp@suse.de> - 2016-11-03 16:00 +0100
  Re: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and  PHIR3MWAIT bit Thomas Gleixner <tglx@linutronix.de> - 2016-11-03 18:10 +0100
    RE: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and  PHIR3MWAIT bit "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> - 2016-11-04 07:50 +0100
      RE: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and  PHIR3MWAIT bit Thomas Gleixner <tglx@linutronix.de> - 2016-11-07 22:00 +0100

csiph-web