Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower
Date	2016-11-03 04:00 +0100
Message-ID	<szgpY-6hH-5@gated-at.bofh.it> (permalink)
References	<sxVxf-3oI-3@gated-at.bofh.it> <sxVxf-3oI-1@gated-at.bofh.it> <szeHv-5qX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Wed, 2 Nov 2016 20:00:03 -0500

> On 10/30/2016 05:21 AM, John Heenan wrote:
>> Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to
>> set
>> macpower, is never 0xea. It is only ever 0x01 (first time after
>> modprobe)
>> using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These
>> results
>> occurs with 'Fix for authentication failure' [PATCH 1/2] in place.
>>
>> Whatever was returned, code tests always showed that at least
>> rtl8xxxu_init_queue_reserved_page(priv);
>> is always required. Not called if macpower set to true.
>>
>> Please see cover letter, [PATCH 0/2], for more information from tests.
> 
> That cover letter will NOT be included in the commit message, thus
> referring to it here is totally pointless.

This is why when a patch series is added to GIT, the cover letter
must be added to the merge commit that adds that series.

It is therefore perfectly valid to refer to such text from a
commit contained by that merge commit.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan <john@zgus.com> - 2016-10-30 11:30 +0100
  Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-10-30 13:10 +0100
    Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan <john@zgus.com> - 2016-10-30 15:00 +0100
      Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-10-31 00:10 +0100
        Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Joe Perches <joe@perches.com> - 2016-11-03 09:50 +0100
          Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Larry Finger <Larry.Finger@lwfinger.net> - 2016-11-03 16:50 +0100
          Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-11-04 15:10 +0100
  Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Larry Finger <Larry.Finger@lwfinger.net> - 2016-11-03 02:10 +0100
    Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower David Miller <davem@davemloft.net> - 2016-11-03 04:00 +0100

csiph-web