Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512031

[PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

Show all headers | View raw

Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set
macpower, is never 0xea. It is only ever 0x01 (first time after modprobe)
using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results
occurs with 'Fix for authentication failure' [PATCH 1/2] in place.

Whatever was returned, code tests always showed that at least
rtl8xxxu_init_queue_reserved_page(priv);
is always required. Not called if macpower set to true.

Please see cover letter, [PATCH 0/2], for more information from tests.

For rtl8xxxu-devel branch of git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git

Signed-off-by: John Heenan <john@zgus.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index f25b4df..aae05f3 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -3904,6 +3904,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
 		macpower = false;
 	else
 		macpower = true;
+	macpower = false; // Code testing shows macpower must always be set to false to avoid failure
 
 	ret = fops->power_on(priv);
 	if (ret < 0) {
-- 
2.10.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan <john@zgus.com> - 2016-10-30 11:30 +0100
  Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-10-30 13:10 +0100
    Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan <john@zgus.com> - 2016-10-30 15:00 +0100
      Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-10-31 00:10 +0100
        Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Joe Perches <joe@perches.com> - 2016-11-03 09:50 +0100
          Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Larry Finger <Larry.Finger@lwfinger.net> - 2016-11-03 16:50 +0100
          Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-11-04 15:10 +0100
  Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower Larry Finger <Larry.Finger@lwfinger.net> - 2016-11-03 02:10 +0100
    Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine  macpower David Miller <davem@davemloft.net> - 2016-11-03 04:00 +0100

csiph-web