Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515074
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times |
| Date | 2016-11-04 09:40 +0100 |
| Message-ID | <szIcx-7IN-11@gated-at.bofh.it> (permalink) |
| References | <szt3P-6jb-1@gated-at.bofh.it> <szt3Q-6jb-23@gated-at.bofh.it> <szuCB-7nG-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/11/4 2:02, Jaegeuk Kim wrote:
> On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> i_times of inode will be set with current system time which can be
>> configured through 'date', so it's not safe to judge dnode block as
>> garbage data depend on i_times.
>
> This is not to detect garbage data, but to skip redundant unchanged inode.
Oops, seems 807b1e1c8e08 ("f2fs: do not recover from previous remained wrong
dnodes") did't describe like that. But after reading the codes, it looks like
the purpose of this change is to skip unchanged inode. So, commit log in
original is incorrect, right?
Thanks,
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] f2fs: fix wrong i_atime recovery Chao Yu <chao@kernel.org> - 2016-11-03 17:30 +0100
[PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Chao Yu <chao@kernel.org> - 2016-11-03 17:30 +0100
Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-03 19:10 +0100
Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Chao Yu <yuchao0@huawei.com> - 2016-11-04 09:40 +0100
Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-05 00:00 +0100
Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Chao Yu <chao@kernel.org> - 2016-11-05 04:20 +0100
Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-05 08:10 +0100
csiph-web