Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515070
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec |
| Date | 2016-11-04 09:20 +0100 |
| Message-ID | <szHTb-7Cp-3@gated-at.bofh.it> (permalink) |
| References | <szl6h-XB-1@gated-at.bofh.it> <szl6i-XB-25@gated-at.bofh.it> <szlSG-1wU-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Nov 3, 2016 at 4:45 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Nov 03, 2016 at 03:55:55PM +0800, Chen-Yu Tsai wrote:
>> The Hummingbird A31 has headset and line in audio jacks and an onboard
>> mic routed to the pins for the SoC's internal codec. The line out pins
>> are routed to an onboard speaker amp, whose output is available on a
>> pin header.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>> arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
>> index 9a74637f677f..48c041b75aab 100644
>> --- a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
>> +++ b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
>> @@ -69,6 +69,19 @@
>> };
>> };
>>
>> +&codec {
>> + allwinner,audio-routing =
>> + "Headphone", "HP",
>> + "Speaker", "LINEOUT",
>> + "LINEIN", "Line In",
>> + "MIC1", "Mic",
>> + "MIC2", "Headset Mic",
>> + "Mic", "MBIAS",
>> + "Headset Mic", "HBIAS";
>> + allwinner,pa-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>> + status = "okay";
>> +};
>> +
>> &cpu0 {
>> cpu-supply = <®_dcdc3>;
>> };
>> @@ -152,6 +165,13 @@
>> };
>>
>> &pio {
>> + codec_pa_pin: codec_pa_pin@0 {
>> + allwinner,pins = "PH22";
>> + allwinner,function = "gpio_out";
>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> + };
>> +
>
> This pin group isn't used anywhere. Because of the strict thing in
> pinctrl, I'd say it's better to not set it, but then, the pin group is
> useless.
I'll drop the pinmux setting then.
ChenYu
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/14] ASoC: sun4i-codec: Add support for A31 Codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 02/14] ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 02/14] ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 18:40 +0100
Applied "ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 09/14] ASoC: sun4i-codec: Add support for A31 analog microphone inputs Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 analog microphone inputs" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 18:40 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-04 02:10 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-06 20:00 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-07 03:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 playback through headphone output" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 01/14] ASoC: sun4i-codec: Move data structures to add create_card call to quirks Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 01/14] ASoC: sun4i-codec: Move data structures to add create_card call to quirks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Move data structures to add create_card call to quirks" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 18:30 +0100
[PATCH v2 07/14] ASoC: sun4i-codec: Add support for A31 Line In playback Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 07/14] ASoC: sun4i-codec: Add support for A31 Line In playback Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
[PATCH v2 10/14] ASoC: sun4i-codec: Add support for A31 ADC capture path Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 10/14] ASoC: sun4i-codec: Add support for A31 ADC capture path Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:40 +0100
[PATCH v2 11/14] ASoC: sun4i-codec: Add support for A31 board level audio routing Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 11/14] ASoC: sun4i-codec: Add support for A31 board level audio routing Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:40 +0100
Applied "ASoC: sun4i-codec: Add support for A31 board level audio routing" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 12/14] ARM: dts: sun6i: Add audio codec device node Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 03/14] ASoC: sun4i-codec: Revise comments for register definition macros Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 03/14] ASoC: sun4i-codec: Revise comments for register definition macros Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Revise comments for register definition macros" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 08/14] ASoC: sun4i-codec: Add support for A31 Line Out playback Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 Line Out playback" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:50 +0100
Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-04 09:20 +0100
[PATCH v2 05/14] ASoC: sun4i-codec: Add support for optional reset control to quirks Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 05/14] ASoC: sun4i-codec: Add support for optional reset control to quirks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Add support for optional reset control to quirks" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-09 16:10 +0100
[PATCH v2 14/14] ARM: dts: sun6i: sina31s: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:10 +0100
Re: [PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Re: [linux-sunxi] [PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Priit Laes <plaes@plaes.org> - 2016-11-03 10:00 +0100
Applied "ASoC: sun4i-codec: Increase DMA max burst to 8" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
csiph-web