Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515735
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output |
| Date | 2016-11-06 20:00 +0100 |
| Message-ID | <sAAPE-Gs-13@gated-at.bofh.it> (permalink) |
| References | <szl6h-XB-1@gated-at.bofh.it> <szl6h-XB-13@gated-at.bofh.it> <szu9F-6WS-23@gated-at.bofh.it> <szBb3-39R-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Fri, Nov 04, 2016 at 09:08:11AM +0800, Chen-Yu Tsai wrote:
> On Fri, Nov 4, 2016 at 1:36 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Thu, Nov 03, 2016 at 03:55:48PM +0800, Chen-Yu Tsai wrote:
> >> +/* headphone controls */
> >> +static const char * const sun6i_codec_hp_src_enum_text[] = {
> >> + "DAC", "Mixer",
> >> +};
> >> +
> >> +static SOC_ENUM_DOUBLE_DECL(sun6i_codec_hp_src_enum,
> >> + SUN6I_CODEC_OM_DACA_CTRL,
> >> + SUN6I_CODEC_OM_DACA_CTRL_LHPIS,
> >> + SUN6I_CODEC_OM_DACA_CTRL_RHPIS,
> >> + sun6i_codec_hp_src_enum_text);
> >> +
> >> +static const struct snd_kcontrol_new sun6i_codec_hp_src[] = {
> >> + SOC_DAPM_ENUM("Headphone Source Playback Route",
> >> + sun6i_codec_hp_src_enum),
> >> +};
> >
> > What is that route exactly? A muxer?
>
> Yup. The following is part of the widgets list later in the code:
>
> + /* Headphone output path */
> + SND_SOC_DAPM_MUX("Headphone Source Playback Route",
> + SND_SOC_NOPM, 0, 0, sun6i_codec_hp_src),
Oh, right.
You can add my Acked-by on this one and the other patches too.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/14] ASoC: sun4i-codec: Add support for A31 Codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 02/14] ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 02/14] ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 18:40 +0100
Applied "ASoC: sun4i-codec: Expand quirks to handle register offsets and card creation" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 09/14] ASoC: sun4i-codec: Add support for A31 analog microphone inputs Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 analog microphone inputs" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 18:40 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-04 02:10 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-06 20:00 +0100
Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Chen-Yu Tsai <wens@csie.org> - 2016-11-07 03:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 playback through headphone output" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 01/14] ASoC: sun4i-codec: Move data structures to add create_card call to quirks Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 01/14] ASoC: sun4i-codec: Move data structures to add create_card call to quirks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Move data structures to add create_card call to quirks" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 18:30 +0100
[PATCH v2 07/14] ASoC: sun4i-codec: Add support for A31 Line In playback Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 07/14] ASoC: sun4i-codec: Add support for A31 Line In playback Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
[PATCH v2 10/14] ASoC: sun4i-codec: Add support for A31 ADC capture path Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 10/14] ASoC: sun4i-codec: Add support for A31 ADC capture path Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:40 +0100
[PATCH v2 11/14] ASoC: sun4i-codec: Add support for A31 board level audio routing Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 11/14] ASoC: sun4i-codec: Add support for A31 board level audio routing Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:40 +0100
Applied "ASoC: sun4i-codec: Add support for A31 board level audio routing" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 12/14] ARM: dts: sun6i: Add audio codec device node Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 03/14] ASoC: sun4i-codec: Revise comments for register definition macros Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 03/14] ASoC: sun4i-codec: Revise comments for register definition macros Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Revise comments for register definition macros" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
[PATCH v2 08/14] ASoC: sun4i-codec: Add support for A31 Line Out playback Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Applied "ASoC: sun4i-codec: Add support for A31 Line Out playback" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-04 21:50 +0100
[PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:50 +0100
Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-04 09:20 +0100
[PATCH v2 05/14] ASoC: sun4i-codec: Add support for optional reset control to quirks Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
Re: [PATCH v2 05/14] ASoC: sun4i-codec: Add support for optional reset control to quirks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Applied "ASoC: sun4i-codec: Add support for optional reset control to quirks" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-09 16:10 +0100
[PATCH v2 14/14] ARM: dts: sun6i: sina31s: Enable internal audio codec Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:00 +0100
[PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Chen-Yu Tsai <wens@csie.org> - 2016-11-03 09:10 +0100
Re: [PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-03 09:30 +0100
Re: [linux-sunxi] [PATCH v2 04/14] ASoC: sun4i-codec: Increase DMA max burst to 8 Priit Laes <plaes@plaes.org> - 2016-11-03 10:00 +0100
Applied "ASoC: sun4i-codec: Increase DMA max burst to 8" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-03 21:40 +0100
csiph-web