Re: [PATCH] drm/tegra: dpaux: Fix error handling

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Jon Hunter <jonathanh@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/tegra: dpaux: Fix error handling
Date	Mon, 31 Oct 2016 13:00:01 +0100
Message-ID	<syjpT-1Qu-9@gated-at.bofh.it> (permalink)
References	<sxbup-6lx-13@gated-at.bofh.it>
X-Original-To	Christophe JAILLET <christophe.jaillet@wanadoo.fr>, <thierry.reding@gmail.com>, <airlied@linux.ie>, <swarren@wwwdotorg.org>, <gnurou@gmail.com>, <treding@nvidia.com>
X-PGP-Universal	processed; by hqnvupgp07.nvidia.com on Sun, 30 Oct 2016 16:50:05 -0700
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version	1.0
X-Originating-IP	[10.21.132.110]
X-Clientproxiedby	DRUKMAIL101.nvidia.com (10.25.59.19) To UKMAIL101.nvidia.com (10.26.138.13)
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	<dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
X-Original-Date	Mon, 31 Oct 2016 10:14:39 +0000
X-Original-Message-ID	<a9b8df12-6643-fe22-e650-23654a2fab77@nvidia.com>
X-Original-References	<20161028090945.11573-1-christophe.jaillet@wanadoo.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1512516

Show key headers only | View raw

On 28/10/16 10:09, Christophe JAILLET wrote:
> 'devm_pinctrl_register()' returns an error pointer or a valid handle. So
> checking for NULL here is pointless and can never trigger.
>
> Check the returned value with IS_ERR instead and propagate this value as
> done in the other functions which call 'devm_pinctrl_register()'
>
> Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/tegra/dpaux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
> index 059f409556d5..2fde44c3a1b3 100644
> --- a/drivers/gpu/drm/tegra/dpaux.c
> +++ b/drivers/gpu/drm/tegra/dpaux.c
> @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
>  	dpaux->desc.owner = THIS_MODULE;
>
>  	dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
> -	if (!dpaux->pinctrl) {
> +	if (IS_ERR(dpaux->pinctrl)) {
>  		dev_err(&pdev->dev, "failed to register pincontrol\n");
> -		return -ENODEV;
> +		return PTR_ERR(dpaux->pinctrl);
>  	}
>  #endif
>  	/* enable and clear all interrupts */

Thanks for the fix!

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

Thread

[PATCH] drm/tegra: dpaux: Fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-10-28 11:20 +0200
  Re: [PATCH] drm/tegra: dpaux: Fix error handling Jon Hunter <jonathanh@nvidia.com> - 2016-10-31 13:00 +0100
  Re: [PATCH] drm/tegra: dpaux: Fix error handling Thierry Reding <thierry.reding@gmail.com> - 2016-11-07 13:10 +0100

csiph-web