Re: [PATCH] drm/tegra: dpaux: Fix error handling

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/tegra: dpaux: Fix error handling
Date	2016-11-07 13:10 +0100
Message-ID	<sAQUq-2Vd-41@gated-at.bofh.it> (permalink)
References	<sxbup-6lx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Oct 28, 2016 at 11:09:45AM +0200, Christophe JAILLET wrote:
> 'devm_pinctrl_register()' returns an error pointer or a valid handle. So
> checking for NULL here is pointless and can never trigger.
> 
> Check the returned value with IS_ERR instead and propagate this value as
> done in the other functions which call 'devm_pinctrl_register()'
> 
> Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support")
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/tegra/dpaux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tegra: dpaux: Fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-10-28 11:20 +0200
  Re: [PATCH] drm/tegra: dpaux: Fix error handling Jon Hunter <jonathanh@nvidia.com> - 2016-10-31 13:00 +0100
  Re: [PATCH] drm/tegra: dpaux: Fix error handling Thierry Reding <thierry.reding@gmail.com> - 2016-11-07 13:10 +0100

csiph-web