Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513353

Re: [PATCH net 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks

Show all headers | View raw

From: Johan Hovold <johan@kernel.org>
Date: Tue,  1 Nov 2016 12:03:35 +0100

> diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c b/drivers/net/ethernet/ti/cpsw-phy-sel.c
> index 054a8dd23dae..589beb843f56 100644
> --- a/drivers/net/ethernet/ti/cpsw-phy-sel.c
> +++ b/drivers/net/ethernet/ti/cpsw-phy-sel.c
> @@ -176,8 +176,11 @@ void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave)
>  	}
>  
>  	dev = bus_find_device(&platform_bus_type, NULL, node, match);
> +	of_node_put(node);
>  	priv = dev_get_drvdata(dev);
>  
> +	put_device(dev);
> +
>  	priv->cpsw_phy_sel(priv, phy_mode, slave);
>  }
>  EXPORT_SYMBOL_GPL(cpsw_phy_sel);

The only reference you have to 'dev' is the one obtained from the
bus_find_device() call, therefore you must at least hold onto
'dev' until after the priv->cpsw_phy_sel(priv, phy_mode, slave); call.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks Johan Hovold <johan@kernel.org> - 2016-11-01 12:10 +0100
  Re: [PATCH net 2/4] net: ethernet: ti: cpsw: fix device and  of_node leaks David Miller <davem@davemloft.net> - 2016-11-01 17:30 +0100
    Re: [PATCH net 2/4] net: ethernet: ti: cpsw: fix device and of_node  leaks Johan Hovold <johan@kernel.org> - 2016-11-01 17:50 +0100
      Re: [PATCH net 2/4] net: ethernet: ti: cpsw: fix device and  of_node leaks David Miller <davem@davemloft.net> - 2016-11-01 18:00 +0100
        Re: [PATCH net 2/4] net: ethernet: ti: cpsw: fix device and of_node  leaks Johan Hovold <johan@kernel.org> - 2016-11-01 18:10 +0100

csiph-web