Re: [PATCH] kbuild: add %/built-in.o target in top Makefile

From	Michal Marek <mmarek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kbuild: add %/built-in.o target in top Makefile
Date	2016-11-01 17:30 +0100
Message-ID	<syK6K-2Be-15@gated-at.bofh.it> (permalink)
References	<svMRr-7EB-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-10-24 14:45, Wei Yang wrote:

> diff --git a/Makefile b/Makefile
> index addb235..546998e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1627,6 +1627,8 @@ endif
>  	$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
>  %.symtypes: %.c prepare scripts FORCE
>  	$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> +%/built-in.o: prepare scripts
> +	$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)

This rule gets in the way of

   975  # The actual objects are generated when descending,
   976  # make sure no implicit rule kicks in
   977  $(sort $(vmlinux-deps)): $(vmlinux-dirs) ;

Quickly looking at the Makefile, it may be fine, but it needs to be
confirmed. This also explains why the current behavior with */built-in.o
is inconsistent.

Michal

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kbuild: add %/built-in.o target in top Makefile Michal Marek <mmarek@suse.com> - 2016-11-01 17:30 +0100
  Re: [PATCH] kbuild: add %/built-in.o target in top Makefile Wei Yang <richard.weiyang@gmail.com> - 2016-11-02 00:00 +0100

csiph-web