Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1513187

Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY

From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY
Date 2016-11-01 10:50 +0100
Message-ID <syDRD-6U0-19@gated-at.bofh.it> (permalink)
References <syo6d-4ZT-7@gated-at.bofh.it> <syo6e-4ZT-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello.

On 10/31/2016 7:56 PM, Neil Armstrong wrote:

> Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d1bf381..71670c3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -47,6 +47,24 @@
>
>  / {
>  	compatible = "amlogic,meson-gxl";
> +
> +

    No need for these empty lines.

> +};
> +
> +&ethmac {
> +	reg = <0x0 0xc9410000 0x0 0x10000
> +	       0x0 0xc8834540 0x0 0x4>;
> +
> +	clocks = <&clkc CLKID_ETH>,
> +		 <&clkc CLKID_FCLK_DIV2>,
> +		 <&clkc CLKID_MPLL2>;
> +	clock-names = "stmmaceth", "clkin0", "clkin1";
> +
> +	mdio0: mdio0 {

    Should be "mdio0: mdio {" in oprder to comply woth the DT spec.

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +	};
>  };
>
>  &aobus {
[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
    Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit  and 32bit register sizes Andrew Lunn <andrew@lunn.ch> - 2016-10-31 20:10 +0100
    Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit  and 32bit register sizes Rob Herring <robh@kernel.org> - 2016-11-09 19:30 +0100
  [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
    Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with  internal PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-01 10:50 +0100
  [RFC PATCH v2 5/5] ARM64: dts: meson-gxl-s905x: Enable internal ethernet PHY Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  [RFC PATCH v2 4/5] ARM64: dts: meson-gxl-p23x: Enable ethernet Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  Re: [RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL Neil Armstrong <narmstrong@baylibre.com> - 2016-11-04 12:00 +0100

csiph-web