Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518372

Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes

Show all headers | View raw

On Mon, Oct 31, 2016 at 05:56:23PM +0100, Neil Armstrong wrote:
> In order to support PHY switching on Amlogic GXL SoCs, add support for
> 16bit and 32bit registers sizes.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  .../devicetree/bindings/net/mdio-mux-mmioreg.txt   |  4 +-
>  drivers/net/phy/mdio-mux-mmioreg.c                 | 60 +++++++++++++++++-----
>  2 files changed, 49 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt b/Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
> index 8516929..065e8bd 100644
> --- a/Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
> +++ b/Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
> @@ -3,7 +3,7 @@ Properties for an MDIO bus multiplexer controlled by a memory-mapped device
>  This is a special case of a MDIO bus multiplexer.  A memory-mapped device,
>  like an FPGA, is used to control which child bus is connected.  The mdio-mux
>  node must be a child of the memory-mapped device.  The driver currently only

As you're touching this sentence, this describes the binding, not a 
driver. With that,

Acked-by: Rob Herring <robh@kernel.org>

> -supports devices with eight-bit registers.
> +supports devices with 8, 16 or 32-bit registers.
>  
>  Required properties in addition to the generic multiplexer properties:
>  
> @@ -11,7 +11,7 @@ Required properties in addition to the generic multiplexer properties:
>  
>  - reg : integer, contains the offset of the register that controls the bus
>  	multiplexer.  The size field in the 'reg' property is the size of
> -	register, and must therefore be 1.
> +	register, and must therefore be 1, 2, or 4.
>  
>  - mux-mask : integer, contains an eight-bit mask that specifies which
>  	bits in the register control the actual bus multiplexer.  The

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
    Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit  and 32bit register sizes Andrew Lunn <andrew@lunn.ch> - 2016-10-31 20:10 +0100
    Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit  and 32bit register sizes Rob Herring <robh@kernel.org> - 2016-11-09 19:30 +0100
  [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
    Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with  internal PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-01 10:50 +0100
  [RFC PATCH v2 5/5] ARM64: dts: meson-gxl-s905x: Enable internal ethernet PHY Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  [RFC PATCH v2 4/5] ARM64: dts: meson-gxl-p23x: Enable ethernet Neil Armstrong <narmstrong@baylibre.com> - 2016-10-31 18:00 +0100
  Re: [RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL Neil Armstrong <narmstrong@baylibre.com> - 2016-11-04 12:00 +0100

csiph-web